Add a pre-check step for creating INDIS connections

CHANGELOG.md

@@ -14,6 +14,9 @@ and what APIs have changed, if applicable.
 
 ## [Unreleased]
 
+## [29.75.3] - 2025-09-05
+- Add XdsClientValidator to pre check xDS client connection 
+
 ## [29.75.2] - 2025-09-05
 - Rename the outlier detection field in the D2 cluster
 
@@ -5891,7 +5894,8 @@ patch operations can re-use these classes for generating patch messages.
 
 ## [0.14.1]
 
-[Unreleased]: https://github.com/linkedin/rest.li/compare/v29.75.2...master
+[Unreleased]: https://github.com/linkedin/rest.li/compare/v29.75.3...master
+[29.75.3]: https://github.com/linkedin/rest.li/compare/v29.75.2...v29.75.3
 [29.75.2]: https://github.com/linkedin/rest.li/compare/v29.75.1...v29.75.2
 [29.75.1]: https://github.com/linkedin/rest.li/compare/v29.75.0...v29.75.1
 [29.75.0]: https://github.com/linkedin/rest.li/compare/v29.74.4...v29.75.0

build.gradle

@@ -126,6 +126,7 @@ project.ext.externalDependency = [
   'grpcNettyShaded'        : 'io.grpc:grpc-netty-shaded:1.68.3',
   'grpcProtobuf'           : 'io.grpc:grpc-protobuf:1.68.3',
   'grpcStub'               : 'io.grpc:grpc-stub:1.68.3',
+  'grpcServices'           : 'io.grpc:grpc-services:1.68.3',
   'protoc'                 : 'com.google.protobuf:protoc:3.25.5',
   'protobufJava'           : 'com.google.protobuf:protobuf-java:3.25.5',
   'protobufJavaUtil'       : 'com.google.protobuf:protobuf-java-util:3.25.5',

d2/build.gradle

@@ -39,6 +39,7 @@ dependencies {
   compile externalDependency.grpcNettyShaded
   compile externalDependency.grpcProtobuf
   compile externalDependency.grpcStub
+  compile externalDependency.grpcServices
   compile externalDependency.protobufJava
   compile externalDependency.protobufJavaUtil
   compile externalDependency.envoyApi

d2/src/main/java/com/linkedin/d2/balancer/D2ClientBuilder.java

@@ -50,6 +50,7 @@
 import com.linkedin.d2.discovery.stores.zk.ZooKeeper;
 import com.linkedin.d2.jmx.XdsServerMetricsProvider;
 import com.linkedin.d2.jmx.JmxManager;
+import com.linkedin.d2.xds.XdsClientValidator;
 import com.linkedin.d2.jmx.NoOpJmxManager;
 import com.linkedin.r2.transport.common.TransportClientFactory;
 import com.linkedin.r2.transport.http.client.HttpClientFactory;
@@ -236,7 +237,9 @@ public D2Client build()
                   _config.disableDetectLiRawD2Client,
                   _config.isLiRawD2Client,
                   _config.xdsStreamMaxRetryBackoffSeconds,
-                  _config.xdsChannelKeepAliveTimeMins
+                  _config.xdsChannelKeepAliveTimeMins,
+                  _config.xdsMinimumJavaVersion,
+                  _config.actionOnPrecheckFailure
     );
 
     final LoadBalancerWithFacilitiesFactory loadBalancerFactory = (_config.lbWithFacilitiesFactory == null) ?
@@ -853,6 +856,18 @@ public D2ClientBuilder setXdsStreamMaxRetryBackoffSeconds(int xdsStreamMaxRetryB
     return this;
   }
 
+  public D2ClientBuilder setXdsMinimumJavaVersion(String xdsMinimumJavaVersion)
+  {
+    _config.xdsMinimumJavaVersion = xdsMinimumJavaVersion;
+    return this;
+  }
+
+  public D2ClientBuilder setActionOnPrecheckFailure(XdsClientValidator.ActionOnPrecheckFailure actionOnPrecheckFailure)
+  {
+    _config.actionOnPrecheckFailure = actionOnPrecheckFailure;
+    return this;
+  }
+
   private Map<String, TransportClientFactory> createDefaultTransportClientFactories()
   {
     final Map<String, TransportClientFactory> clientFactories = new HashMap<>();

d2/src/main/java/com/linkedin/d2/balancer/D2ClientConfig.java

@@ -30,13 +30,15 @@
 import com.linkedin.d2.balancer.util.downstreams.DownstreamServicesFetcher;
 import com.linkedin.d2.balancer.util.healthcheck.HealthCheckOperations;
 import com.linkedin.d2.balancer.util.partitions.PartitionAccessorRegistry;
+import com.linkedin.d2.xds.XdsClientValidator;
 import com.linkedin.d2.balancer.zkfs.ZKFSTogglingLoadBalancerFactoryImpl;
 import com.linkedin.d2.balancer.zkfs.ZKFSTogglingLoadBalancerFactoryImpl.ComponentFactory;
 import com.linkedin.d2.discovery.event.LogOnlyServiceDiscoveryEventEmitter;
 import com.linkedin.d2.discovery.event.ServiceDiscoveryEventEmitter;
 import com.linkedin.d2.discovery.stores.zk.ZKPersistentConnection;
 import com.linkedin.d2.discovery.stores.zk.ZooKeeper;
 import com.linkedin.d2.discovery.stores.zk.ZooKeeperStore;
+import com.linkedin.d2.xds.XdsClientValidator.ActionOnPrecheckFailure;
 import com.linkedin.d2.jmx.XdsServerMetricsProvider;
 import com.linkedin.d2.jmx.JmxManager;
 import com.linkedin.d2.jmx.NoOpXdsServerMetricsProvider;
@@ -52,6 +54,8 @@
 import javax.net.ssl.SSLContext;
 import javax.net.ssl.SSLParameters;
 
+import static com.linkedin.d2.xds.XdsClientValidator.DEFAULT_MINIMUM_JAVA_VERSION;
+
 public class D2ClientConfig
 {
   // default values for some configs, to be shared with other classes
@@ -178,6 +182,8 @@ public class D2ClientConfig
   public boolean loadBalanceStreamException = false;
   public boolean xdsInitialResourceVersionsEnabled = false;
   public Integer xdsStreamMaxRetryBackoffSeconds = null;
+  public String xdsMinimumJavaVersion = DEFAULT_MINIMUM_JAVA_VERSION;
+  public XdsClientValidator.ActionOnPrecheckFailure actionOnPrecheckFailure = ActionOnPrecheckFailure.WARN;
 
   /**
    * D2 client builder by default will detect if it's used to build a raw D2 client (as opposed to used by standard
@@ -272,7 +278,9 @@ public D2ClientConfig()
                  boolean disableDetectLiRawD2Client,
                  boolean isLiRawD2Client,
                  Integer xdsStreamMaxRetryBackoffSeconds,
-                 Long xdsChannelKeepAliveTimeMins)
+                 Long xdsChannelKeepAliveTimeMins,
+                 String xdsMinimumJavaVersion,
+                 XdsClientValidator.ActionOnPrecheckFailure actionOnPrecheckFailure)
   {
     this.zkHosts = zkHosts;
     this.xdsServer = xdsServer;
@@ -352,5 +360,7 @@ public D2ClientConfig()
     this.disableDetectLiRawD2Client = disableDetectLiRawD2Client;
     this.isLiRawD2Client = isLiRawD2Client;
     this.xdsStreamMaxRetryBackoffSeconds = xdsStreamMaxRetryBackoffSeconds;
+    this.xdsMinimumJavaVersion = xdsMinimumJavaVersion;
+    this.actionOnPrecheckFailure = actionOnPrecheckFailure;
   }
 }

d2/src/main/java/com/linkedin/d2/xds/XdsClientImpl.java

@@ -46,6 +46,7 @@
 import java.util.ArrayList;
 import java.util.Collection;
 import java.util.Collections;
+import java.util.concurrent.atomic.AtomicBoolean;
 import java.util.HashMap;
 import java.util.HashSet;
 import java.util.List;
@@ -77,6 +78,7 @@ public class XdsClientImpl extends XdsClient
       new RateLimitedLogger(_log, TimeUnit.MINUTES.toMillis(1), SystemClock.instance());
   public static final long DEFAULT_READY_TIMEOUT_MILLIS = 2000L;
   public static final Integer DEFAULT_MAX_RETRY_BACKOFF_SECS = 30; // default value for max retry backoff seconds
+  public static final String DEFAULT_MINIMUM_JAVA_VERSION = "1.8.0_282"; // default value for minimum Java version required for XDS client
 
   /**
    * The resource subscribers maps the resource type to its subscribers. Note that the {@link ResourceType#D2_URI}
@@ -103,6 +105,7 @@ public class XdsClientImpl extends XdsClient
   @VisibleForTesting
   AdsStream _adsStream;
   private boolean _isXdsStreamShutdown;
+  private final AtomicBoolean _preCheckCompleted = new AtomicBoolean(false);
   @VisibleForTesting
   ScheduledFuture<?> _retryRpcStreamFuture;
   private ScheduledFuture<?> _readyTimeoutFuture;
@@ -111,6 +114,8 @@ public class XdsClientImpl extends XdsClient
   private final XdsClientJmx _xdsClientJmx;
   private final XdsServerMetricsProvider _serverMetricsProvider;
   private final boolean _initialResourceVersionsEnabled;
+  private final String _minimumJavaVersion;
+  private final XdsClientValidator.ActionOnPrecheckFailure _actionOnPrecheckFailure;
 
   @Deprecated
   public XdsClientImpl(Node node, ManagedChannel managedChannel, ScheduledExecutorService executorService)
@@ -168,6 +173,7 @@ public XdsClientImpl(Node node,
         irvSupport, null);
   }
 
+  @Deprecated
   public XdsClientImpl(Node node,
       ManagedChannel managedChannel,
       ScheduledExecutorService executorService,
@@ -176,6 +182,21 @@ public XdsClientImpl(Node node,
       XdsServerMetricsProvider serverMetricsProvider,
       boolean irvSupport,
       Integer maxRetryBackoffSeconds)
+  {
+    this(node, managedChannel, executorService, readyTimeoutMillis, subscribeToUriGlobCollection,
+        serverMetricsProvider, irvSupport, maxRetryBackoffSeconds, DEFAULT_MINIMUM_JAVA_VERSION, XdsClientValidator.ActionOnPrecheckFailure.WARN);
+  }
+
+  public XdsClientImpl(Node node,
+      ManagedChannel managedChannel,
+      ScheduledExecutorService executorService,
+      long readyTimeoutMillis,
+      boolean subscribeToUriGlobCollection,
+      XdsServerMetricsProvider serverMetricsProvider,
+      boolean irvSupport,
+      Integer maxRetryBackoffSeconds,
+      String minimumJavaVersion,
+      XdsClientValidator.ActionOnPrecheckFailure actionOnPrecheckFailure)
   {
     _readyTimeoutMillis = readyTimeoutMillis;
     _node = node;
@@ -195,6 +216,12 @@ public XdsClientImpl(Node node,
       _log.info("XDS initial resource versions support enabled");
     }
 
+    _minimumJavaVersion = minimumJavaVersion == null ? DEFAULT_MINIMUM_JAVA_VERSION : minimumJavaVersion;
+    _log.info("Minimum Java version required: {}", _minimumJavaVersion);
+
+    _actionOnPrecheckFailure = actionOnPrecheckFailure == null ? XdsClientValidator.ActionOnPrecheckFailure.WARN : actionOnPrecheckFailure;
+    _log.info("Action on pre-check failure: {}", _actionOnPrecheckFailure);
+
     _retryBackoffPolicy = _backoffPolicyProvider.get();
     Integer backoffSecs = (maxRetryBackoffSeconds != null && maxRetryBackoffSeconds > 0)
         ? maxRetryBackoffSeconds : DEFAULT_MAX_RETRY_BACKOFF_SECS;
@@ -206,6 +233,14 @@ public XdsClientImpl(Node node,
   public void start()
   {
     _xdsClientJmx.setXdsClient(this);
+
+    // Run pre-check only once at startup
+    if (!_preCheckCompleted.get())
+    {
+      XdsClientValidator.preCheckForIndisConnection(_managedChannel, _readyTimeoutMillis, _minimumJavaVersion, _actionOnPrecheckFailure);
+      _preCheckCompleted.set(true);
+    }
+
     startRpcStream();
   }