-
Notifications
You must be signed in to change notification settings - Fork 387
fix: [M3-10709] - firewall_id error on LKE pool update
#13109
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
pmakode-akamai
merged 6 commits into
linode:develop
from
pmakode-akamai:M3-10709-fix-firewallid-error-on-lke-pool-update
Nov 20, 2025
Merged
fix: [M3-10709] - firewall_id error on LKE pool update
#13109
pmakode-akamai
merged 6 commits into
linode:develop
from
pmakode-akamai:M3-10709-fix-firewallid-error-on-lke-pool-update
Nov 20, 2025
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
...ernetes/KubernetesClusterDetail/NodePoolsDisplay/ConfigureNodePool/ConfigureNodePoolForm.tsx
Show resolved
Hide resolved
tanushree-akamai
approved these changes
Nov 19, 2025
Contributor
tanushree-akamai
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @pmakode-akamai!
bnussman-akamai
approved these changes
Nov 19, 2025
Collaborator
Cloud Manager UI test results🎉 862 passing tests on test run #5 ↗︎
|
tanushree-akamai
pushed a commit
to tanushree-akamai/manager
that referenced
this pull request
Nov 21, 2025
* Fix firewall_id error on LKE E pool update * Added changeset: The `firewall_id` error on LKE pool update * Add comments and update false check instances * Revert accidental removal of update_strategy
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Approved
Multiple approvals and ready to merge!
Bug
Fixes for regressions or bugs
LKE
Related to Linode Kubernetes Engine offerings
LKE-Enterprise
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description 📝
This PR updates the default value for the
firewall_idfield in the Configure Node Pool form to useundefinedwhen the initial node pool's firewall value isnull.Previously, when the initial node pool's
firewall_idwasnull, React Hook Form treated the field as having an invalid initial value. This caused the form to block submission even when no validation errors existed. Removing or commenting out the default value worked, but was not a right solution because we want the field to remain controlled and properly initialized and sometimes a required field when we user selectsSelect existing firewallradio in the form.Request payload can either omit
firewall_idwhen it is not required, or includefirewall_idwith a value when it is needed.Changes 🔄
Scope 🚢
Target release date 🗓️
N/A
Preview 📷
How to test 🧪
Reproduction steps
firewall_id cannot be nullvalidation error is displayedVerification steps
nullSelect existing firewallradio option is selectedAuthor Checklists
As an Author, to speed up the review process, I considered 🤔
👀 Doing a self review
❔ Our contribution guidelines
🤏 Splitting feature into small PRs
➕ Adding a changeset
🧪 Providing/improving test coverage
🔐 Removing all sensitive information from the code and PR description
🚩 Using a feature flag to protect the release
👣 Providing comprehensive reproduction steps
📑 Providing or updating our documentation
🕛 Scheduling a pair reviewing session
📱 Providing mobile support
♿ Providing accessibility support
As an Author, before moving this PR from Draft to Open, I confirmed ✅