Skip to content

fix: [M3-10709] - firewall_id error on LKE pool update #13109

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Nov 20, 2025
Merged

fix: [M3-10709] - firewall_id error on LKE pool update #13109

Show file tree
Hide file tree
Changes from 5 commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
562216f
Fix firewall_id error on LKE E pool update
pmakode-akamai Nov 18, 2025
699f805
Merge branch 'develop' into M3-10709-fix-firewallid-error-on-lke-pool…
pmakode-akamai Nov 18, 2025
42ba15a
Merge branch 'develop' into M3-10709-fix-firewallid-error-on-lke-pool…
pmakode-akamai Nov 19, 2025
3f9635a
Added changeset: The `firewall_id` error on LKE pool update
pmakode-akamai Nov 19, 2025
6df35cb
Add comments and update false check instances
pmakode-akamai Nov 19, 2025
a7e004d
Revert accidental removal of update_strategy
pmakode-akamai Nov 19, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions packages/manager/.changeset/pr-13109-fixed-1763535418420.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"@linode/manager": Fixed
---

The `firewall_id` error on LKE pool update ([#13109](https://github.com/linode/manager/pull/13109))
11 changes: 8 additions & 3 deletions ...etes/KubernetesClusterDetail/NodePoolsDisplay/ConfigureNodePool/ConfigureNodePoolForm.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,8 +46,13 @@ export const ConfigureNodePoolForm = (props: Props) => {
// @TODO allow users to edit Node Pool `label` and `tags` because the API supports it. (ECE-353)
// label: nodePool.label,
// tags: nodePool.tags,
firewall_id: nodePool.firewall_id,
update_strategy: nodePool.update_strategy,

/**
* We set the default value of the form field to `undefined` if `nodePool.firewall_id` is null.
* This ensures the field remains controlled in React Hook Form and is properly initialized,
* preventing unexpected validation errors when the initial value is null.
*/
firewall_id: nodePool.firewall_id ?? undefined,
k8s_version: nodePool.k8s_version,
},
});
Expand Down Expand Up @@ -87,7 +92,7 @@ export const ConfigureNodePoolForm = (props: Props) => {
clusterTier={clusterTier ?? 'standard'}
firewallSelectOptions={{
allowFirewallRemoval: clusterTier === 'standard',
...(nodePool.firewall_id !== 0 && {
...(nodePool.firewall_id !== null && {
disableDefaultFirewallRadio: true,
defaultFirewallRadioTooltip:
"You can't use this option once an existing Firewall has been selected.",
Expand Down
Loading