Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug fixes for filters and pagination #9

Merged
5 commits merged into from
Nov 21, 2023
Merged

Conversation

samrawks
Copy link

@samrawks samrawks commented Nov 3, 2023

Bug

@samrawks samrawks linked an issue Nov 3, 2023 that may be closed by this pull request
@mikestreety
Copy link
Contributor

@samrawks This looks much better!

Only thing I noticed is the "Show entries" select box is missing it's little chevron to show it is a select box and not an input box

Screenshot 2023-11-03 at 12 52 49

@mikestreety
Copy link
Contributor

@samrawks Looking at this again, can the rows have a min-height so they are all the same?

image

Can there also be a bit more padding, as it is currently easy to accidentally click the wrong button either vertically or horizontally

Might be worth reducing the padding/font size on the buttons themselves a tad too

@samrawks
Copy link
Author

Added for #5

  • Select menu icon using default browser option
  • Height attributes to table rows to force mininum heights
  • Spacing to Approve/Reject buttons

@mikestreety
Copy link
Contributor

@zaqmughal-ll You happy?

image image

@mikestreety mikestreety requested a review from a user November 21, 2023 08:36
@ghost ghost merged commit ab9812f into main Nov 21, 2023
1 check passed
@mikestreety mikestreety deleted the 5-style-data-module-listing branch June 14, 2024 08:40
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Style data module listing
2 participants