Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug fixes for filters and pagination #9

Merged
5 commits merged into from
Nov 21, 2023
Merged

Bug fixes for filters and pagination #9

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
d70c791
fix(css): Fix the styling of the data tables
Nov 3, 2023
7017bec
fix(css): Fix the styling of the data tables
Nov 3, 2023
f67f641
style(css): Tidy up the CSS and add comments
Nov 3, 2023
5b5c898
docs(upcoming): List the fixes for issue 5
Nov 3, 2023
b4865fe
fix(css): Add select menu icon, add height to table rows, fix button …
Nov 17, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
85 changes: 71 additions & 14 deletions Resources/Public/Css/FeUsersDataTable.css
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,6 @@
.t3js-toggle-recordlist.collapsed img {
transform: rotate(-180deg);
}

.form-control {
margin: 0 0.5rem;
}
Expand All @@ -16,9 +15,8 @@
margin-bottom: 18px;
}
.form-group.usergroups > div label {
margin-left: 18px;;
margin-left: 18px;
}

.dataTables_wrapper {
position: relative;
}
Expand Down Expand Up @@ -53,7 +51,6 @@
.paginate_button {
position: relative;
float: left;
padding: 6px 6px;
margin-left: -1px;
line-height: 1.5;
color: #212424;
Expand All @@ -76,7 +73,38 @@
.paginate_button.disabled::before {
opacity: 0.5;
}
.form-inline {
display: grid;
grid-template-columns: max-content max-content;
grid-gap: 1em;
}

/* Filter styling */
div[id$="table_length"],
div[id$="table_filter"] {
margin: 0;
}
div[id$="table_length"] > label {
display: grid;
grid-template-columns: minmax(20px, 40px) auto;
margin: 0;
}
div[id$="table_length"] > label > select {
order: 10;
grid-column: span 2;
margin: 0;
-moz-appearance: auto; /* Firefox */
-webkit-appearance: auto; /* Safari and Chrome */
appearance: auto;
}
div[id$="table_filter"] > label > input {
margin: 0;
}

/* Pagination styles */
.paginate_button {
min-height: 42px;
}
.paginate_button.first,
.paginate_button.previous,
.paginate_button.next,
Expand All @@ -87,21 +115,50 @@
.paginate_button.previous::before,
.paginate_button.next::before,
.paginate_button.last::before {
background-size: 1em 1em;
width: 20px;
height: 20px;
content: '';
display: inline-block;
background-image: url('/typo3/sysext/core/Resources/Public/Icons/T3Icons/actions/actions-view-paging-first.svg');
background-repeat: no-repeat;
background-size: contain;
width: 1.8rem;
height: 1.8rem;
display: block;
font-size: 22px;
color: #000;
}
.paginate_button.first::before {
background-image: url("data:image/svg+xml;base64,PHN2ZyB4bWxucz0iaHR0cDovL3d3dy53My5vcmcvMjAwMC9zdmciIHhtbDpzcGFjZT0icHJlc2VydmUiIHZpZXdCb3g9IjAgMCAxNiAxNiI+PGcgZmlsbD0iY3VycmVudENvbG9yIj48cGF0aCBkPSJtOC40MTQgOCAzLjUzNi0zLjUzNi0uNzA3LS43MDdMNyA4bDQuMjQzIDQuMjQzLjcwNy0uNzA3ek01IDRoMXY4SDV6Ii8+PC9nPjwvc3ZnPg==");
}

.paginate_button.previous::before {
background-image: url('/typo3/sysext/core/Resources/Public/Icons/T3Icons/actions/actions-view-paging-previous.svg');
background-image: url("data:image/svg+xml;base64,PHN2ZyB4bWxucz0iaHR0cDovL3d3dy53My5vcmcvMjAwMC9zdmciIHhtbDpzcGFjZT0icHJlc2VydmUiIHZpZXdCb3g9IjAgMCAxNiAxNiI+PGcgZmlsbD0iY3VycmVudENvbG9yIj48cGF0aCBkPSJNNi40MTQgOCA5Ljk1IDQuNDY0bC0uNzA3LS43MDdMNSA4bDQuMjQzIDQuMjQzLjcwNy0uNzA3eiIvPjwvZz48L3N2Zz4=");
}
.paginate_button.next::before {
background-image: url('/typo3/sysext/core/Resources/Public/Icons/T3Icons/actions/actions-view-paging-next.svg');
background-image: url("data:image/svg+xml;base64,PHN2ZyB4bWxucz0iaHR0cDovL3d3dy53My5vcmcvMjAwMC9zdmciIHhtbDpzcGFjZT0icHJlc2VydmUiIHZpZXdCb3g9IjAgMCAxNiAxNiI+PGcgZmlsbD0iY3VycmVudENvbG9yIj48cGF0aCBkPSJNOS41ODYgOCA2LjA1IDExLjUzNmwuNzA3LjcwN0wxMSA4IDYuNzU3IDMuNzU3bC0uNzA3LjcwN3oiLz48L2c+PC9zdmc+");
}
.paginate_button.last::before {
background-image: url('/typo3/sysext/core/Resources/Public/Icons/T3Icons/actions/actions-view-paging-last.svg');
background-image: url("data:image/svg+xml;base64,PHN2ZyB4bWxucz0iaHR0cDovL3d3dy53My5vcmcvMjAwMC9zdmciIHhtbDpzcGFjZT0icHJlc2VydmUiIHZpZXdCb3g9IjAgMCAxNiAxNiI+PGcgZmlsbD0iY3VycmVudENvbG9yIj48cGF0aCBkPSJNNy41ODYgOCA0LjA1IDExLjUzNmwuNzA3LjcwN0w5IDggNC43NTcgMy43NTdsLS43MDcuNzA3ek0xMCA0aDF2OGgtMXoiLz48L2c+PC9zdmc+");
}

/* Hide the ellipses */
div[id$="table_paginate"] > span > span,
.dataTables_paginate > span > span {
display: none;
}

/* Padding normalization for pagination buttons */
div[id$="table_paginate"] > span > .paginate_button,
.dataTables_paginate > span > .paginate_button {
padding: 11px 13px;
}
div[id$="table_paginate"] > .paginate_button,
.dataTables_paginate > .paginate_button {
padding: 9px 13px;
}

table[id$='table'] > tbody > tr {
height: 4rem;
}
table[id$='table'] > tbody > tr button {
margin-right: 0.75rem;
font-size: 0.7rem;
}
table[id$='table'] > tbody > tr a.btn {
font-size: 0.7rem;
}
6 changes: 6 additions & 0 deletions UPCOMING.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
# Bug

#### Bug
* Fixed the styles the search filters #5
* Added the icons back to the pagination using Typo3 icon set #5