-
Notifications
You must be signed in to change notification settings - Fork 571
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Temp fix to make soft inpainting work #494
Conversation
How do I apply it ? |
still no PR, is Forge not being updated? |
Thank you good man!!! I've been trying all day to figure out how Soft Inpainting works! And I can't understand how it works because it doesn't work in Forge. And now it works! :DDDDDDDDDDDD |
is this fix still work for the newly updated forge? or the new forge fix this issue itself? |
fixed in main codebase |
Addresses #490 -- this PR is more or less to bring this to attention.
This isn't the correct fix as this undoes a couple changes made by @lllyasviel, but I'm unsure what the correct solution is here.
mask_before_denoising
is only ever set toTrue
here, but that code is not present in Forge, meaning it's alwaysFalse
.Relevant
apply_blend
code adapted from here: https://github.com/AUTOMATIC1111/stable-diffusion-webui/blob/eee46a5094f748ebe9fe4978b0d440a8ebbab4a6/modules/sd_samplers_cfg_denoiser.py#L168-L178