Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Temp fix to make soft inpainting work #494

Closed

Conversation

catboxanon
Copy link
Collaborator

@catboxanon catboxanon commented Mar 5, 2024

Addresses #490 -- this PR is more or less to bring this to attention.

This isn't the correct fix as this undoes a couple changes made by @lllyasviel, but I'm unsure what the correct solution is here. mask_before_denoising is only ever set to True here, but that code is not present in Forge, meaning it's always False.

Relevant apply_blend code adapted from here: https://github.com/AUTOMATIC1111/stable-diffusion-webui/blob/eee46a5094f748ebe9fe4978b0d440a8ebbab4a6/modules/sd_samplers_cfg_denoiser.py#L168-L178

@afrofail
Copy link

afrofail commented Mar 6, 2024

This solved the problem! Thank you for taking the time to figure this out!

Forge
Forge

Automatic1111
Automatic1111

@youlijie
Copy link

How do I apply it ?
I changed the code manually like the commit but still do nothing for me.

@watercat93
Copy link

still no PR, is Forge not being updated?

@rollingcookies
Copy link

Адрес № 490 — этот пиар более или менее направлен на то, чтобы привлечь к этому внимание.

Это неверное исправление, поскольку оно отменяет пару изменений, внесенных @lllyasviel, но я не уверен, какое здесь правильное решение. mask_before_denoisingвсегда устанавливается только на True здесь , но этого кода нет в Forge, то есть он всегда False.

Соответствующий apply_blendкод адаптирован отсюда: https://github.com/AUTOMATIC1111/stable-diffusion-webui/blob/eee46a5094f748ebe9fe4978b0d440a8ebbab4a6/modules/sd_samplers_cfg_denoiser.py#L168-L178

Thank you good man!!! I've been trying all day to figure out how Soft Inpainting works! And I can't understand how it works because it doesn't work in Forge. And now it works! :DDDDDDDDDDDD
Already dug the whole internet, and since I work in Forge, I wouldn't have known it was a bug.

@WingeD123
Copy link

is this fix still work for the newly updated forge? or the new forge fix this issue itself?

@lllyasviel
Copy link
Owner

fixed in main codebase

@lllyasviel lllyasviel closed this Aug 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants