Fix: fclose call with nullptr#357

Merged

KIwabuchi merged 2 commits intollnl:developfrom

dice-group:fix/fclose-on-nullptr

Jul 10, 2025

Contributor

liss-h commented Jul 9, 2025 •

edited

Loading

Tiny fix:

Calling fclose with nullptr is UB.
And create_file potentially leaked a fd if an fsync call failed

liss-h added 2 commits

July 9, 2025 16:43


          fix fclose on nullptr

d4bf6da


          fix forgotten fclose

a8c85f1

Member

KIwabuchi commented Jul 10, 2025

@liss-h Nice catch! Thanks!

KIwabuchi merged commit 9bcf71c into llnl:develop

2 checks passed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet