Skip to content

Fix: fclose call with nullptr #357

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
KIwabuchi merged 2 commits into from
Jul 10, 2025
Merged

Fix: fclose call with nullptr #357

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d4bf6da
fix fclose on nullptr
liss-h Jul 9, 2025
a8c85f1
fix forgotten fclose
liss-h Jul 10, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion include/metall/detail/file.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -184,7 +184,10 @@ inline bool create_file(const fs::path &file_path) {
logger::perror(logger::level::error, __FILE__, __LINE__, ss.str().c_str());
return false;
}
if (!os_fsync(fd)) return false;
if (!os_fsync(fd)) {
os_close(fd);
return false;
}
if (!os_close(fd)) return false;

// Sync the parent directory
Expand Down
3 changes: 2 additions & 1 deletion include/metall/detail/memory.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -130,8 +130,9 @@ inline std::pair<std::size_t, std::size_t> get_num_page_faults() {
logger::out(logger::level::error, __FILE__, __LINE__, ss.str().c_str());
minflt = majflt = 0;
}

fclose(f);
}
fclose(f);
#else
#ifdef METALL_VERBOSE_SYSTEM_SUPPORT_WARNING
#warning "get_num_page_faults() is not supported in this environment"
Expand Down