[Comb][AssumeTwoValued] Set twoState=true on all Comb ops#10395
Merged
[Comb][AssumeTwoValued] Set twoState=true on all Comb ops#10395
Conversation
This enables a bunch of Comb canonicalizations; see llvm#10393.
Contributor
Author
|
(we should consider adding AssumeTwoValued in the Arcilator pipelines...) |
fabianschuiki
approved these changes
May 6, 2026
Contributor
fabianschuiki
left a comment
fabianschuiki
left a comment
There was a problem hiding this comment.
LGTM! Good idea to enable this in the Arcilator pipelines. We'll eventually want actual support for X and Z, but how exactly that should look like isn't really clear. Might as well double-down on the two-valuedness until we figure that out 😁
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This enables a bunch of Comb canonicalizations; see #10393.