[FIRRTL] Support domain.define in LowerDomains #9108
+319
−69
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add support for lowering
firrtl.domain.define
operations tofirrtl.propassign
. This uses a technique similar to how the dialectconversion framework works where unrealized conversion casts are used to
deal with the progressive lowering of ports by introducing "stubs" (0-1
placeholders) to allow ports to be erased and then "spliced" (1-1
conversions) after the ports are inserted with now-incompatible types
before finally converting defines to propassigns.