Feedback

llvm · Nov 6, 2024 · 4c814a2 · 4c814a2
1 parent a0da17c
commit 4c814a2
Showing 1 changed file with 3 additions and 2 deletions.
diff --git a/mlir/lib/Dialect/Vector/IR/VectorOps.cpp b/mlir/lib/Dialect/Vector/IR/VectorOps.cpp
@@ -1713,10 +1713,11 @@ static Value foldExtractFromBroadcast(ExtractOp extractOp) {
 ///     : vector<8xf32>, vector<8xf32>
 ///   %extract = vector.extract %shuffle[3] : f32 from vector<4xf32>
 /// ->
-///   %extract = vector.extract %b[7] : f32 from vector<4xf32>
+///   %extract = vector.extract %b[7] : f32 from vector<8xf32>
 ///
 static Value foldExtractFromShuffle(ExtractOp extractOp) {
-  // TODO: Canonicalization for dynamic position not implemented yet.
+  // Dynamic positions are not folded as the resulting code would be more
+  // complex than the input code.
   if (extractOp.hasDynamicPosition())
     return Value();