Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[HLSL] Add Increment/DecrementCounter methods to structured buffers #114148

Open
wants to merge 8 commits into
base: main
Choose a base branch
from

Commits on Oct 29, 2024

  1. [HLSL] Add Increment/DecrementCounter methods to structured buffers

    Introduces `__builtin_hlsl_buffer_update_counter` clang buildin that is used to implement IncrementCounter and DecrementCounter methods on RWStructuredBuffer and RasterizerOrderedStructuredBuffer. The builtin is translated to LLVM intrisics llvm.dx.bufferUpdateCounter/llvm.spv.bufferUpdateCounter.
    
    Introduces `BuiltinTypeMethodBuilder` helper in `HLSLExternalSemaSource` that allows adding methods to builtin types
    using the builder pattern like this:
    
       BuiltinTypeMethodBuilder(Sema, RecordBuilder, "MethodName", ReturnType)
           .addParam("param_name", Type, InOutModifier)
           .callBuiltin("buildin_name", { BuiltinParams })
           .finalizeMethod();
    
    Fixes llvm#113513
    hekota committed Oct 29, 2024
    Configuration menu
    Copy the full SHA
    8c76f28 View commit details
    Browse the repository at this point in the history

Commits on Nov 1, 2024

  1. Code review feedback - add test & asserts, add Sema to main decl buil…

    …der, fix generated CallExpr type
    hekota committed Nov 1, 2024
    Configuration menu
    Copy the full SHA
    a94c901 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    eb26a6f View commit details
    Browse the repository at this point in the history

Commits on Nov 5, 2024

  1. Code review feedback - assert of completed definition or no method body

    Do not complete definition if we already got one from precompiled headers.
    hekota committed Nov 5, 2024
    Configuration menu
    Copy the full SHA
    0f4c61f View commit details
    Browse the repository at this point in the history
  2. clang-format

    hekota committed Nov 5, 2024
    Configuration menu
    Copy the full SHA
    f180391 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    942af76 View commit details
    Browse the repository at this point in the history

Commits on Nov 6, 2024

  1. Configuration menu
    Copy the full SHA
    8119cd0 View commit details
    Browse the repository at this point in the history

Commits on Nov 7, 2024

  1. Configuration menu
    Copy the full SHA
    ed6d0f9 View commit details
    Browse the repository at this point in the history