-
Notifications
You must be signed in to change notification settings - Fork 11.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[HLSL] Add Increment
/DecrementCounter
methods to structured buffers
#114148
Open
hekota
wants to merge
8
commits into
llvm:main
Choose a base branch
from
hekota:sb4-counter
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Commits on Oct 29, 2024
-
[HLSL] Add Increment/DecrementCounter methods to structured buffers
Introduces `__builtin_hlsl_buffer_update_counter` clang buildin that is used to implement IncrementCounter and DecrementCounter methods on RWStructuredBuffer and RasterizerOrderedStructuredBuffer. The builtin is translated to LLVM intrisics llvm.dx.bufferUpdateCounter/llvm.spv.bufferUpdateCounter. Introduces `BuiltinTypeMethodBuilder` helper in `HLSLExternalSemaSource` that allows adding methods to builtin types using the builder pattern like this: BuiltinTypeMethodBuilder(Sema, RecordBuilder, "MethodName", ReturnType) .addParam("param_name", Type, InOutModifier) .callBuiltin("buildin_name", { BuiltinParams }) .finalizeMethod(); Fixes llvm#113513
Configuration menu - View commit details
-
Copy full SHA for 8c76f28 - Browse repository at this point
Copy the full SHA 8c76f28View commit details
Commits on Nov 1, 2024
-
Code review feedback - add test & asserts, add Sema to main decl buil…
…der, fix generated CallExpr type
Configuration menu - View commit details
-
Copy full SHA for a94c901 - Browse repository at this point
Copy the full SHA a94c901View commit details -
Configuration menu - View commit details
-
Copy full SHA for eb26a6f - Browse repository at this point
Copy the full SHA eb26a6fView commit details
Commits on Nov 5, 2024
-
Code review feedback - assert of completed definition or no method body
Do not complete definition if we already got one from precompiled headers.
Configuration menu - View commit details
-
Copy full SHA for 0f4c61f - Browse repository at this point
Copy the full SHA 0f4c61fView commit details -
Configuration menu - View commit details
-
Copy full SHA for f180391 - Browse repository at this point
Copy the full SHA f180391View commit details -
Configuration menu - View commit details
-
Copy full SHA for 942af76 - Browse repository at this point
Copy the full SHA 942af76View commit details
Commits on Nov 6, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 8119cd0 - Browse repository at this point
Copy the full SHA 8119cd0View commit details
Commits on Nov 7, 2024
-
Configuration menu - View commit details
-
Copy full SHA for ed6d0f9 - Browse repository at this point
Copy the full SHA ed6d0f9View commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.