[libc] add an _Exit declaration to the _Exit proxy func header

[Jobhdez]

This improves/fixes this pr #114718. In this pr we added an _Exit declaration to hdr/func/_Exit.h instead of the stdlib.h header based on comments from @nickdesaulniers.

[llvmbot]

@llvm/pr-subscribers-libc

Author: Job Henandez Lara (Jobhdez)

Changes

This improves/fixes this pr #114718. In this pr we added an _Exit declaration to hdr/func/_Exit.h instead of the stdlib.h header based on comments from @nickdesaulniers.

---

Full diff: https://github.com/llvm/llvm-project/pull/114904.diff

1 Files Affected:

• (modified) libc/hdr/func/_Exit.h (+1-2)

diff --git a/libc/hdr/func/_Exit.h b/libc/hdr/func/_Exit.h
index e024a651a50bcf..b8160e9af3e4e3 100644
--- a/libc/hdr/func/_Exit.h
+++ b/libc/hdr/func/_Exit.h
@@ -10,8 +10,7 @@
 #define LLVM_LIBC_HDR_FUNC_EXIT_H
 
 #ifdef LIBC_FULL_BUILD
-// We will use the `_Exit` declaration from our generated stdlib.h
-#include <stdlib.h>
+extern "C" [[noreturn]] void _Exit(int) noexcept;
 
 #else // Overlay mode
 

[michaelrj-google]

Why do we need a proxy header for _Exit at all? Why don't we just call our internal _Exit in the atexit and atquickexit tests?

[Jobhdez]

Why do we need a proxy header for _Exit at all? Why don't we just call our internal _Exit in the atexit and atquickexit tests?

Yeah this makes sense. I will update the PR to remove the _Exit proxy header, and switch those 2 tests to use LIBC_NAMESPACE::_Exit instead. Can you please just confirm that this is what we’re going to do? Thanks

[michaelrj-google]

Yes that sounds like the correct thing to do. Thank you!

[Jobhdez]

Yes that sounds like the correct thing to do. Thank you!

No problem!

[michaelrj-google]

LGTM, please update the title and description

[Jobhdez]

LGTM, please update the title and description

ok I will. do you want me to merge after I change the title? or do you want to merge yourself?

[michaelrj-google]

This should be fine to merge as-is. I'd recommend waiting until the morning to merge it (so that people can help troubleshoot if necessary), but it's up to you.

[Jobhdez]

This should be fine to merge as-is. I'd recommend waiting until the morning to merge it (so that people can help troubleshoot if necessary), but it's up to you.

ok ill wait until tomorrow morning. thanks. can you please suggest a new title for the pr? thanks