[HLSL][DirectX] Add support for rootsig
as a target environment
#156373
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pr implements support for a root signature as a target, as specified here.
This is implemented in the following steps:
rootsignature
as a shader model environment type and definerootsig
as atarget_profile
. Only valid as versions 1.0 and 1HLSLFrontendAction
to invoke a special handling of constructing theASTContext
if we are considering anhlsl
file and with arootsignature
targetParser
andSema
to insert theRootSignatureDecl
CGHLSLRuntime
to emit the constructed root signature decl as part ofdx.rootsignatures
with anull
entry functionDXILRootSignature
to handle emitting a root signature without an entry functionToolChains/HLSL
to invokeonly-section=RTS0
to strip any other generated informationResolves: #150286.
Implementation Considerations
Ideally we could invoke this as part of
clang-dxc
without the need of a source file. However, the initialization of theParser
andLexer
becomes quite complicated to handle this.Technically, we could avoid generating any of the extra information that is removed in step 6. However, it seems better to re-use the logic in
llvm-objcopy
without any need for additional custom logic inDXILRootSignature
.