[libc][bazel] Fix missing fmodbf16 dependency #157149
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tests were failing due to a missing dependency on fputil/bfloat16.
michaelrj-google
requested review from
rupprecht,
keith and
aaronmondal
as code owners
|
@llvm/pr-subscribers-libc Author: Michael Jones (michaelrj-google) ChangesTests were failing due to a missing dependency on fputil/bfloat16. Full diff: https://github.com/llvm/llvm-project/pull/157149.diff 2 Files Affected:
diff --git a/utils/bazel/llvm-project-overlay/libc/BUILD.bazel b/utils/bazel/llvm-project-overlay/libc/BUILD.bazel
index 5df4394ca5d93..bb76da4153108 100644
--- a/utils/bazel/llvm-project-overlay/libc/BUILD.bazel
+++ b/utils/bazel/llvm-project-overlay/libc/BUILD.bazel
@@ -3751,6 +3751,7 @@ libc_math_function(
libc_math_function(
name = "fmodbf16",
additional_deps = [
+ ":__support_fputil_bfloat16",
":__support_fputil_generic_fmod",
],
)
diff --git a/utils/bazel/llvm-project-overlay/libc/test/src/math/smoke/BUILD.bazel b/utils/bazel/llvm-project-overlay/libc/test/src/math/smoke/BUILD.bazel
index 07d95fb18e883..2bffcdea58478 100644
--- a/utils/bazel/llvm-project-overlay/libc/test/src/math/smoke/BUILD.bazel
+++ b/utils/bazel/llvm-project-overlay/libc/test/src/math/smoke/BUILD.bazel
@@ -740,7 +740,12 @@ math_test(
math_test(
name = "fmodbf16",
- hdrs = ["FModTest.h"],
+ hdrs = [
+ "FModTest.h",
+ ],
+ deps = [
+ "//libc:__support_fputil_bfloat16",
+ ],
)
math_test(
|
rupprecht
approved these changes
Sep 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tests were failing due to a missing dependency on fputil/bfloat16.