Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[workflows] Only build native targets in ci-ubuntu-22.04 container #94649

Closed
wants to merge 1 commit into from

Conversation

tstellar
Copy link
Collaborator

@tstellar tstellar commented Jun 6, 2024

This should help reduce the build times.

@llvmbot
Copy link
Collaborator

llvmbot commented Jun 6, 2024

@llvm/pr-subscribers-github-workflow

Author: Tom Stellard (tstellar)

Changes

This should help reduce the build times.


Full diff: https://github.com/llvm/llvm-project/pull/94649.diff

1 Files Affected:

  • (modified) .github/workflows/containers/github-action-ci/stage1.Dockerfile (+2)
diff --git a/.github/workflows/containers/github-action-ci/stage1.Dockerfile b/.github/workflows/containers/github-action-ci/stage1.Dockerfile
index 8c6bcf4638410..6a8819d8e1af1 100644
--- a/.github/workflows/containers/github-action-ci/stage1.Dockerfile
+++ b/.github/workflows/containers/github-action-ci/stage1.Dockerfile
@@ -32,7 +32,9 @@ RUN mkdir build
 RUN cmake -B ./build -G Ninja ./llvm \
   -C ./clang/cmake/caches/BOLT-PGO.cmake \
   -DBOOTSTRAP_LLVM_ENABLE_LLD=ON \
+  -DBOOTSTRAP_LLVM_TARGETS_TO_BUILD=Native \
   -DBOOTSTRAP_BOOTSTRAP_LLVM_ENABLE_LLD=ON \
+  -DBOOTSTRAP_BOOTSTRAP_LLVM_TARGETS_TO_BUILD=Native \
   -DPGO_INSTRUMENT_LTO=Thin \
   -DLLVM_ENABLE_RUNTIMES="compiler-rt" \
   -DCMAKE_INSTALL_PREFIX="$LLVM_SYSROOT" \

Copy link
Contributor

@boomanaiden154 boomanaiden154 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I didn't realize that the second and third stages didn't already use a native-only build, although it makes a lot of sense in hindsight.

@tstellar
Copy link
Collaborator Author

tstellar commented Jun 6, 2024

This did not work as expected. I'm looking into it.

@tstellar
Copy link
Collaborator Author

tstellar commented Jun 6, 2024

I see the issue. The 3 stages already build the native target only, but when llvm is built to generate the training data, it enables all the targets.

@tstellar
Copy link
Collaborator Author

tstellar commented Jun 6, 2024

It turns out we don't need this, closing.

@tstellar tstellar closed this Jun 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants