Skip to content

feat: update iOS icon and splashscreen#780

Open
tamang29 wants to merge 7 commits into
mainfrom
feat/ios-icon-update
Open

feat: update iOS icon and splashscreen#780
tamang29 wants to merge 7 commits into
mainfrom
feat/ios-icon-update

Conversation

@tamang29

@tamang29 tamang29 commented Jun 22, 2026

Copy link
Copy Markdown
Contributor

Summary

Update icon and splashscreen for iOS app

Release note

Implementation notes

Screenshots / screencasts

Screenshot 2026-07-06 at 11 49 04

Checklist

  • Linked to a related issue (if applicable)
  • Added a changeset whose summary is written in the user's voice (pnpm changeset, how) — or this PR doesn't touch a Changesets-tracked package (@tumaet/apollon, @tumaet/webapp, @tumaet/server)
  • PR title's Conventional Commit type (feat/fix/…) matches the kind of change — it groups the release note
  • Tests added or updated
  • Documentation updated (if applicable)
  • Screenshots or screencasts attached (if a UI change)

@Claudia-Anthropica Claudia-Anthropica left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tamang29 The new image assets mostly fit the stated goal, but the native iOS project picked up behavior-changing edits. Please restore the app identity/signing settings and finish updating the splash image set; the failing e2e check looks unrelated to these files.

MARKETING_VERSION = 1.0;
OTHER_SWIFT_FLAGS = "$(inherited) \"-D\" \"COCOAPODS\" \"-DDEBUG\"";
PRODUCT_BUNDLE_IDENTIFIER = de.tum.cit.ase.apollon;
PRODUCT_BUNDLE_IDENTIFIER = de.tum.cit.ase.apollon99;

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tamang29 [high] This changes the iOS app identity from de.tum.cit.ase.apollon to de.tum.cit.ase.apollon99 and also commits a DEVELOPMENT_TEAM in both Debug and Release. That will make this build/sign as a different app and break installs or updates for the existing bundle, so please keep the original bundle identifier and leave team selection out of the project file.

🤖 Prompt for AI agents

In standalone/webapp/ios/App/App.xcodeproj/project.pbxproj, the Debug and Release build settings changed PRODUCT_BUNDLE_IDENTIFIER to de.tum.cit.ase.apollon99 and added DEVELOPMENT_TEAM. Restore PRODUCT_BUNDLE_IDENTIFIER to de.tum.cit.ase.apollon in both configurations and remove the DEVELOPMENT_TEAM entries.

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tamang29 Still seeing this in the current commit: Debug and Release both still set DEVELOPMENT_TEAM = AQY72VTZTL; and PRODUCT_BUNDLE_IDENTIFIER = de.tum.cit.ase.apollon99;. Please restore the original bundle identifier and remove the committed team setting.

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tamang29 This still needs one more cleanup: the bundle ID is back to de.tum.cit.ase.apollon, but DEVELOPMENT_TEAM = AQY72VTZTL; is still committed in both Debug and Release. Please remove those two team entries from the project file.

Comment thread .changeset/three-socks-teach.md

@Claudia-Anthropica Claudia-Anthropica left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tamang29 The two requested changes are still open: the iOS project still changes the bundle/signing settings, and the splash asset set still only updates one referenced PNG. Please address those existing threads before this is ready.

@Claudia-Anthropica Claudia-Anthropica left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tamang29 The splash asset set is fixed now, thanks. The iOS project still commits DEVELOPMENT_TEAM = AQY72VTZTL; in both Debug and Release though, so I’m keeping this as changes requested until those signing-team entries are removed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: In progress

Development

Successfully merging this pull request may close these issues.

3 participants