feat: update iOS icon and splashscreen#780
Conversation
Claudia-Anthropica
left a comment
There was a problem hiding this comment.
@tamang29 The new image assets mostly fit the stated goal, but the native iOS project picked up behavior-changing edits. Please restore the app identity/signing settings and finish updating the splash image set; the failing e2e check looks unrelated to these files.
| MARKETING_VERSION = 1.0; | ||
| OTHER_SWIFT_FLAGS = "$(inherited) \"-D\" \"COCOAPODS\" \"-DDEBUG\""; | ||
| PRODUCT_BUNDLE_IDENTIFIER = de.tum.cit.ase.apollon; | ||
| PRODUCT_BUNDLE_IDENTIFIER = de.tum.cit.ase.apollon99; |
There was a problem hiding this comment.
@tamang29 [high] This changes the iOS app identity from de.tum.cit.ase.apollon to de.tum.cit.ase.apollon99 and also commits a DEVELOPMENT_TEAM in both Debug and Release. That will make this build/sign as a different app and break installs or updates for the existing bundle, so please keep the original bundle identifier and leave team selection out of the project file.
🤖 Prompt for AI agents
In standalone/webapp/ios/App/App.xcodeproj/project.pbxproj, the Debug and Release build settings changed PRODUCT_BUNDLE_IDENTIFIER to de.tum.cit.ase.apollon99 and added DEVELOPMENT_TEAM. Restore PRODUCT_BUNDLE_IDENTIFIER to de.tum.cit.ase.apollon in both configurations and remove the DEVELOPMENT_TEAM entries.
There was a problem hiding this comment.
@tamang29 Still seeing this in the current commit: Debug and Release both still set DEVELOPMENT_TEAM = AQY72VTZTL; and PRODUCT_BUNDLE_IDENTIFIER = de.tum.cit.ase.apollon99;. Please restore the original bundle identifier and remove the committed team setting.
There was a problem hiding this comment.
@tamang29 This still needs one more cleanup: the bundle ID is back to de.tum.cit.ase.apollon, but DEVELOPMENT_TEAM = AQY72VTZTL; is still committed in both Debug and Release. Please remove those two team entries from the project file.
Claudia-Anthropica
left a comment
There was a problem hiding this comment.
@tamang29 The two requested changes are still open: the iOS project still changes the bundle/signing settings, and the splash asset set still only updates one referenced PNG. Please address those existing threads before this is ready.
Claudia-Anthropica
left a comment
There was a problem hiding this comment.
@tamang29 The splash asset set is fixed now, thanks. The iOS project still commits DEVELOPMENT_TEAM = AQY72VTZTL; in both Debug and Release though, so I’m keeping this as changes requested until those signing-team entries are removed.
Summary
Update icon and splashscreen for iOS app
Release note
Implementation notes
Screenshots / screencasts
Checklist
pnpm changeset, how) — or this PR doesn't touch a Changesets-tracked package (@tumaet/apollon,@tumaet/webapp,@tumaet/server)feat/fix/…) matches the kind of change — it groups the release note