Skip to content
Open
Show file tree
Hide file tree
Changes from 5 commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/three-socks-teach.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"@tumaet/webapp": patch
---

Use the Apollon icon for the iOS app
Comment thread
tamang29 marked this conversation as resolved.
36 changes: 19 additions & 17 deletions standalone/webapp/ios/App/App.xcodeproj/project.pbxproj
Original file line number Diff line number Diff line change
Expand Up @@ -10,29 +10,29 @@
2FAD9763203C412B000D30F8 /* config.xml in Resources */ = {isa = PBXBuildFile; fileRef = 2FAD9762203C412B000D30F8 /* config.xml */; };
50379B232058CBB4000EE86E /* capacitor.config.json in Resources */ = {isa = PBXBuildFile; fileRef = 50379B222058CBB4000EE86E /* capacitor.config.json */; };
504EC3081FED79650016851F /* AppDelegate.swift in Sources */ = {isa = PBXBuildFile; fileRef = 504EC3071FED79650016851F /* AppDelegate.swift */; };
AB10000000000000000000A1 /* ApollonLegacyModels.swift in Sources */ = {isa = PBXBuildFile; fileRef = AB10000000000000000000A2 /* ApollonLegacyModels.swift */; };
AB10000000000000000000B1 /* LegacyMigrationPlugin.swift in Sources */ = {isa = PBXBuildFile; fileRef = AB10000000000000000000B2 /* LegacyMigrationPlugin.swift */; };
AB10000000000000000000D1 /* MainViewController.swift in Sources */ = {isa = PBXBuildFile; fileRef = AB10000000000000000000D2 /* MainViewController.swift */; };
504EC30D1FED79650016851F /* Main.storyboard in Resources */ = {isa = PBXBuildFile; fileRef = 504EC30B1FED79650016851F /* Main.storyboard */; };
504EC30F1FED79650016851F /* Assets.xcassets in Resources */ = {isa = PBXBuildFile; fileRef = 504EC30E1FED79650016851F /* Assets.xcassets */; };
504EC3121FED79650016851F /* LaunchScreen.storyboard in Resources */ = {isa = PBXBuildFile; fileRef = 504EC3101FED79650016851F /* LaunchScreen.storyboard */; };
50B271D11FEDC1A000F3C39B /* public in Resources */ = {isa = PBXBuildFile; fileRef = 50B271D01FEDC1A000F3C39B /* public */; };
A084ECDBA7D38E1E42DFC39D /* Pods_App.framework in Frameworks */ = {isa = PBXBuildFile; fileRef = AF277DCFFFF123FFC6DF26C7 /* Pods_App.framework */; };
AB10000000000000000000A1 /* ApollonLegacyModels.swift in Sources */ = {isa = PBXBuildFile; fileRef = AB10000000000000000000A2 /* ApollonLegacyModels.swift */; };
AB10000000000000000000B1 /* LegacyMigrationPlugin.swift in Sources */ = {isa = PBXBuildFile; fileRef = AB10000000000000000000B2 /* LegacyMigrationPlugin.swift */; };
AB10000000000000000000D1 /* MainViewController.swift in Sources */ = {isa = PBXBuildFile; fileRef = AB10000000000000000000D2 /* MainViewController.swift */; };
/* End PBXBuildFile section */

/* Begin PBXFileReference section */
2FAD9762203C412B000D30F8 /* config.xml */ = {isa = PBXFileReference; lastKnownFileType = text.xml; path = config.xml; sourceTree = "<group>"; };
50379B222058CBB4000EE86E /* capacitor.config.json */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = text.json; path = capacitor.config.json; sourceTree = "<group>"; };
504EC3041FED79650016851F /* App.app */ = {isa = PBXFileReference; explicitFileType = wrapper.application; includeInIndex = 0; path = App.app; sourceTree = BUILT_PRODUCTS_DIR; };
504EC3071FED79650016851F /* AppDelegate.swift */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.swift; path = AppDelegate.swift; sourceTree = "<group>"; };
AB10000000000000000000A2 /* ApollonLegacyModels.swift */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.swift; path = ApollonLegacyModels.swift; sourceTree = "<group>"; };
AB10000000000000000000B2 /* LegacyMigrationPlugin.swift */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.swift; path = LegacyMigrationPlugin.swift; sourceTree = "<group>"; };
AB10000000000000000000D2 /* MainViewController.swift */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.swift; path = MainViewController.swift; sourceTree = "<group>"; };
504EC30C1FED79650016851F /* Base */ = {isa = PBXFileReference; lastKnownFileType = file.storyboard; name = Base; path = Base.lproj/Main.storyboard; sourceTree = "<group>"; };
504EC30E1FED79650016851F /* Assets.xcassets */ = {isa = PBXFileReference; lastKnownFileType = folder.assetcatalog; path = Assets.xcassets; sourceTree = "<group>"; };
504EC3111FED79650016851F /* Base */ = {isa = PBXFileReference; lastKnownFileType = file.storyboard; name = Base; path = Base.lproj/LaunchScreen.storyboard; sourceTree = "<group>"; };
504EC3131FED79650016851F /* Info.plist */ = {isa = PBXFileReference; lastKnownFileType = text.plist.xml; path = Info.plist; sourceTree = "<group>"; };
50B271D01FEDC1A000F3C39B /* public */ = {isa = PBXFileReference; lastKnownFileType = folder; path = public; sourceTree = "<group>"; };
AB10000000000000000000A2 /* ApollonLegacyModels.swift */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.swift; path = ApollonLegacyModels.swift; sourceTree = "<group>"; };
AB10000000000000000000B2 /* LegacyMigrationPlugin.swift */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.swift; path = LegacyMigrationPlugin.swift; sourceTree = "<group>"; };
AB10000000000000000000D2 /* MainViewController.swift */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.swift; path = MainViewController.swift; sourceTree = "<group>"; };
AF277DCFFFF123FFC6DF26C7 /* Pods_App.framework */ = {isa = PBXFileReference; explicitFileType = wrapper.framework; includeInIndex = 0; path = Pods_App.framework; sourceTree = BUILT_PRODUCTS_DIR; };
AF51FD2D460BCFE21FA515B2 /* Pods-App.release.xcconfig */ = {isa = PBXFileReference; includeInIndex = 1; lastKnownFileType = text.xcconfig; name = "Pods-App.release.xcconfig"; path = "Pods/Target Support Files/Pods-App/Pods-App.release.xcconfig"; sourceTree = "<group>"; };
FC68EB0AF532CFC21C3344DD /* Pods-App.debug.xcconfig */ = {isa = PBXFileReference; includeInIndex = 1; lastKnownFileType = text.xcconfig; name = "Pods-App.debug.xcconfig"; path = "Pods/Target Support Files/Pods-App/Pods-App.debug.xcconfig"; sourceTree = "<group>"; };
Expand Down Expand Up @@ -92,23 +92,23 @@
path = App;
sourceTree = "<group>";
};
AB10000000000000000000C1 /* Migration */ = {
7F8756D8B27F46E3366F6CEA /* Pods */ = {
isa = PBXGroup;
children = (
AB10000000000000000000A2 /* ApollonLegacyModels.swift */,
AB10000000000000000000B2 /* LegacyMigrationPlugin.swift */,
AB10000000000000000000D2 /* MainViewController.swift */,
FC68EB0AF532CFC21C3344DD /* Pods-App.debug.xcconfig */,
AF51FD2D460BCFE21FA515B2 /* Pods-App.release.xcconfig */,
);
path = Migration;
name = Pods;
sourceTree = "<group>";
};
7F8756D8B27F46E3366F6CEA /* Pods */ = {
AB10000000000000000000C1 /* Migration */ = {
isa = PBXGroup;
children = (
FC68EB0AF532CFC21C3344DD /* Pods-App.debug.xcconfig */,
AF51FD2D460BCFE21FA515B2 /* Pods-App.release.xcconfig */,
AB10000000000000000000A2 /* ApollonLegacyModels.swift */,
AB10000000000000000000B2 /* LegacyMigrationPlugin.swift */,
AB10000000000000000000D2 /* MainViewController.swift */,
);
name = Pods;
path = Migration;
sourceTree = "<group>";
};
/* End PBXGroup section */
Expand Down Expand Up @@ -369,12 +369,13 @@
ASSETCATALOG_COMPILER_APPICON_NAME = AppIcon;
CODE_SIGN_STYLE = Automatic;
CURRENT_PROJECT_VERSION = 1;
DEVELOPMENT_TEAM = AQY72VTZTL;
INFOPLIST_FILE = App/Info.plist;
IPHONEOS_DEPLOYMENT_TARGET = 15.0;
LD_RUNPATH_SEARCH_PATHS = "$(inherited) @executable_path/Frameworks";
MARKETING_VERSION = 1.0;
OTHER_SWIFT_FLAGS = "$(inherited) \"-D\" \"COCOAPODS\" \"-DDEBUG\"";
PRODUCT_BUNDLE_IDENTIFIER = de.tum.cit.ase.apollon;
PRODUCT_BUNDLE_IDENTIFIER = de.tum.cit.ase.apollon99;

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tamang29 [high] This changes the iOS app identity from de.tum.cit.ase.apollon to de.tum.cit.ase.apollon99 and also commits a DEVELOPMENT_TEAM in both Debug and Release. That will make this build/sign as a different app and break installs or updates for the existing bundle, so please keep the original bundle identifier and leave team selection out of the project file.

🤖 Prompt for AI agents

In standalone/webapp/ios/App/App.xcodeproj/project.pbxproj, the Debug and Release build settings changed PRODUCT_BUNDLE_IDENTIFIER to de.tum.cit.ase.apollon99 and added DEVELOPMENT_TEAM. Restore PRODUCT_BUNDLE_IDENTIFIER to de.tum.cit.ase.apollon in both configurations and remove the DEVELOPMENT_TEAM entries.

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tamang29 Still seeing this in the current commit: Debug and Release both still set DEVELOPMENT_TEAM = AQY72VTZTL; and PRODUCT_BUNDLE_IDENTIFIER = de.tum.cit.ase.apollon99;. Please restore the original bundle identifier and remove the committed team setting.

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tamang29 This still needs one more cleanup: the bundle ID is back to de.tum.cit.ase.apollon, but DEVELOPMENT_TEAM = AQY72VTZTL; is still committed in both Debug and Release. Please remove those two team entries from the project file.

PRODUCT_NAME = "$(TARGET_NAME)";
SWIFT_ACTIVE_COMPILATION_CONDITIONS = DEBUG;
SWIFT_VERSION = 5.0;
Expand All @@ -389,11 +390,12 @@
ASSETCATALOG_COMPILER_APPICON_NAME = AppIcon;
CODE_SIGN_STYLE = Automatic;
CURRENT_PROJECT_VERSION = 1;
DEVELOPMENT_TEAM = AQY72VTZTL;
INFOPLIST_FILE = App/Info.plist;
IPHONEOS_DEPLOYMENT_TARGET = 15.0;
LD_RUNPATH_SEARCH_PATHS = "$(inherited) @executable_path/Frameworks";
MARKETING_VERSION = 1.0;
PRODUCT_BUNDLE_IDENTIFIER = de.tum.cit.ase.apollon;
PRODUCT_BUNDLE_IDENTIFIER = de.tum.cit.ase.apollon99;
PRODUCT_NAME = "$(TARGET_NAME)";
SWIFT_ACTIVE_COMPILATION_CONDITIONS = "";
SWIFT_VERSION = 5.0;
Expand Down
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
2 changes: 1 addition & 1 deletion standalone/webapp/ios/App/App/Info.plist
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
<key>CFBundleDevelopmentRegion</key>
<string>en</string>
<key>CFBundleDisplayName</key>
<string>Apollon</string>
<string>Apollon</string>
<key>CFBundleExecutable</key>
<string>$(EXECUTABLE_NAME)</string>
<key>CFBundleIdentifier</key>
Expand Down
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading