Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix error in current page example #1262

Merged
merged 8 commits into from
Oct 19, 2023

Conversation

wout
Copy link
Contributor

@wout wout commented Oct 19, 2023

I just noticed and error in the current_page? example where the links weren't wrapped in <li> tags

Copy link
Member

@jwoertink jwoertink left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch! Just minor, but there's some trailing commas here.

src/actions/guides/frontend/rendering_html.cr Outdated Show resolved Hide resolved
src/actions/guides/frontend/rendering_html.cr Outdated Show resolved Hide resolved
Copy link
Member

@jwoertink jwoertink left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@jwoertink jwoertink merged commit b90a413 into luckyframework:main Oct 19, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants