Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix error in current page example #1262

Merged
merged 8 commits into from
Oct 19, 2023
Merged

Fix error in current page example #1262

Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
a9859c5
Add docs for the new inline_svg macro
wout Nov 18, 2022
d3711a3
Merge branch 'luckyframework:main' into main
wout Jan 11, 2023
c080329
Merge branch 'luckyframework:main' into main
wout Aug 17, 2023
3177c4c
Remove SVG builder from awesome page
wout Aug 17, 2023
c83d64a
Merge branch 'luckyframework:main' into main
wout Oct 19, 2023
191d4f1
fix: wrap links in current_page? example in <li> tags
wout Oct 19, 2023
f11a1f1
Update src/actions/guides/frontend/rendering_html.cr
wout Oct 19, 2023
29f5657
Update src/actions/guides/frontend/rendering_html.cr
wout Oct 19, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 9 additions & 10 deletions src/actions/guides/frontend/rendering_html.cr
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -466,20 +466,19 @@ class Guides::Frontend::RenderingHtml < GuideAction
```crystal
nav do
ul do
link "Home",
to: Home::Index,
data_selected: current_page?(Home::Index)
li data_current: current_page?(Home::Index) do
link "Home", to: Home::Index
end

link "Your dashboard",
to: Dashboard::Index,
data_selected: current_page?(Dashboard::Index)
li data_current: current_page?(Dashboard::Index) do
link "Your dashboard", to: Dashboard::Index
end

link "Your profile",
to: Me::Show,
data_selected: current_page?(Me::Show)
li data_current: current_page?(Me::Show) do
link "Your profile", to: Me::Show
end
end
end

```

### Advanced usage
Expand Down