Add GetTaxZoneCountry class to be able to use country based tax zones #1248
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
glennjacobs
approved these changes
Sep 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the
GetTaxZoneclass, there is logic for dealing with postcode-based and state-based tax zones, but not for country-based ones. This PR aims to fill this gap.I've followed the general concept of the existing
GetTaxZonePostcodeandGetTaxZoneStateclasses for the newGetTaxZoneCountryclass.I've assumed that country comes at the bottom of the priority hierarchy: if an address has a postcode matching a
TaxZonePostcode, that takes priority over state and country, after that, state takes priority over country, and only if there's no matching tax zone for postcode or state, we're gonna look for aTaxZoneCountry. This should also help ensure that this is not a breaking change.I've also added some tests.