Allow discounts to be limited to product variants #1285
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
This reverts commit e1bafcf.
|
Thanks @ryanmitchell, I like this idea and had a play around and seems to work. After chatting with @glennjacobs we feel this should be targeting |
|
No problem. Need me to change anything? |
|
@ryanmitchell I don't think so from initial testing, only thing I was looking at was the nested sub query and whether it could be flattened a bit, but hadn't had a real look. |
alecritson
approved these changes
Oct 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the ability to limit discounts to product variants with the corresponding UI changes required in the hub. It also adds a new
product variant searchcomponent to the hub.