Enhancement 10681189884: Upgrade sparrow to 1.4.0 #2789
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
IvoDD
approved these changes
Dec 4, 2025
Collaborator
IvoDD
left a comment
IvoDD
left a comment
There was a problem hiding this comment.
LGTM, can you add a low priority ticket to readd the arrow tests and link to this PR
vasil-pashov
approved these changes
Dec 4, 2025
Collaborator
Author
|
alexowens90
force-pushed
the
enhancement/10681189884/update-sparrow-to-1-4-0
branch
from
99ea7ae to
c7cf14d
Compare
alexowens90
deleted the
enhancement/10681189884/update-sparrow-to-1-4-0
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reference Issues/PRs
10681189884
What does this implement or fix?
Updates sparrow to 1.4.0. This requires a vcpkg baseline update, which does not work out of the box on linux. Binary search of vcpkg commits identifies this as the culprit. We do not seem to be the only project affected (ticket).
This only breaks the build of the arrow dependency, which is only used for testing decimals, which are not yet supported, so for now I've just removed the dependency and corresponding tests.