feat: double-click pane tab to toggle zoom#28
feat: double-click pane tab to toggle zoom#28STRML wants to merge 2 commits intomanaflow-ai:mainfrom
Conversation
Allows the host application to distinguish user-initiated tab closes (clicking the X button) from internal/programmatic closes, so it can decide whether closing the last surface should also close the workspace. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
There was a problem hiding this comment.
Your free trial has ended. If you'd like to continue receiving code reviews, you can add a payment method here.
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (3)
📝 WalkthroughWalkthroughThe pull request introduces two new public-facing APIs: a tab-close request callback in Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~8 minutes Possibly related PRs
Poem
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
📝 Coding Plan
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment Tip CodeRabbit can scan for known vulnerabilities in your dependencies using OSV Scanner.OSV Scanner will automatically detect and report security vulnerabilities in your project's dependencies. No additional configuration is required. |
Summary
TabItemViewthat calls the existingonZoomToggle()callback.onTapGesture(count: 2)placed before the existing single-tap handlerParent cmux PR: manaflow-ai/cmux#1422
Test plan
Summary by cubic
Double-clicking a pane tab now toggles zoom to quickly maximize/restore a split. Added a host callback to detect user-initiated tab closes.
onTabCloseRequestinBonsplitControllerfires when a user closes a tab from the tab strip, allowing hosts to handle workspace-close logic.Written for commit ad798c5. Summary will update on new commits.
Summary by CodeRabbit