feat: double-click pane tab to toggle zoom#1422
feat: double-click pane tab to toggle zoom#1422STRML wants to merge 1 commit intomanaflow-ai:mainfrom
Conversation
|
@STRML is attempting to deploy a commit to the Manaflow Team on Vercel. A member of the Team first needs to authorize it. |
There was a problem hiding this comment.
Your free trial has ended. If you'd like to continue receiving code reviews, you can add a payment method here.
📝 WalkthroughWalkthroughThis pull request adds double-tap gesture recognition to two UI views in ContentView.swift—TabItemView and SidebarEmptyArea—enabling users to toggle split-zoom functionality by double-clicking tabs or the sidebar empty area. Each gesture handler triggers both view selection and the split-zoom toggle. Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes Possibly related PRs
Poem
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
📝 Coding Plan
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment Tip CodeRabbit can enforce grammar and style rules using `languagetool`.Configure the |
There was a problem hiding this comment.
No issues found across 1 file
Since this is your first cubic review, here's how it works:
- cubic automatically reviews your code and comments on bugs and improvements
- Teach cubic by replying to its comments. cubic learns from your replies and gets better over time
- Add one-off context when rerunning by tagging
@cubic-dev-aiwith guidance or docs links (includingllms.txt) - Ask questions if you need clarification on any suggestion
Double-clicking a tab title in the pane tab bar (Bonsplit) now toggles pane zoom, maximizing that pane within the split layout. Uses the existing onZoomToggle callback already wired through TabBarView.
d9f21c8 to
038063e
Compare
|
Conflicted on this since we we might want to make double click "rename workspace/tab" instead... maybe we can have a button for maximizing next to the X that only appears on hover? |
I would suggest that full screen toggle on double click makes more sense - it is the pattern in many other apps. Since you have to type to rename a tab, the cmd+R shortcut seems more convenient. That said, a single click and hover on the tab title is not a bad way to also pop a rename in-place, like renaming in Word or in most file explorers. |
Summary
onZoomTogglecallback already wired throughTabBarViewvendor/bonsplit— adds.onTapGesture(count: 2)before the existing single-tap handlerDepends on: manaflow-ai/bonsplit#28
Test plan