Skip to content

feat: double-click pane tab to toggle zoom#1422

Open
STRML wants to merge 1 commit intomanaflow-ai:mainfrom
STRML:feat/double-click-tab-zoom
Open

feat: double-click pane tab to toggle zoom#1422
STRML wants to merge 1 commit intomanaflow-ai:mainfrom
STRML:feat/double-click-tab-zoom

Conversation

@STRML
Copy link
Copy Markdown

@STRML STRML commented Mar 14, 2026

Summary

  • Double-clicking a tab title in the pane tab bar (Bonsplit) now toggles pane zoom
  • Uses the existing onZoomToggle callback already wired through TabBarView
  • 3-line change in vendor/bonsplit — adds .onTapGesture(count: 2) before the existing single-tap handler

Depends on: manaflow-ai/bonsplit#28

Test plan

  • Open a workspace with multiple splits (Cmd+D)
  • Double-click a tab title in the pane tab bar → that pane should zoom to fill the content area
  • Double-click the tab title again → splits should restore
  • Single-click still selects tabs normally
  • Middle-click still closes tabs
  • Right-click context menu still works

@vercel
Copy link
Copy Markdown

vercel bot commented Mar 14, 2026

@STRML is attempting to deploy a commit to the Manaflow Team on Vercel.

A member of the Team first needs to authorize it.

Copy link
Copy Markdown
Contributor

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Your free trial has ended. If you'd like to continue receiving code reviews, you can add a payment method here.

@coderabbitai
Copy link
Copy Markdown

coderabbitai bot commented Mar 14, 2026

📝 Walkthrough

Walkthrough

This pull request adds double-tap gesture recognition to two UI views in ContentView.swift—TabItemView and SidebarEmptyArea—enabling users to toggle split-zoom functionality by double-clicking tabs or the sidebar empty area. Each gesture handler triggers both view selection and the split-zoom toggle.

Changes

Cohort / File(s) Summary
Double-Tap Gesture Handlers
Sources/ContentView.swift
Added onTapGesture(count: 2) handlers to TabItemView and SidebarEmptyArea that call updateSelection() and tabManager.toggleFocusedSplitZoom() on double-tap events.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Possibly related PRs

Poem

🐰 A double-tap, a magic spell,
Makes split-views dance and swell,
Two taps on tabs, the zoom will flip,
A gesture light, a UI trip! ✨

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Title check ✅ Passed The title accurately describes the main feature added: double-clicking a pane tab to toggle zoom, which is the primary change in this pull request.
Description check ✅ Passed PR description covers all required sections with clear summary, test plan, and dependency information, though missing demo video and incomplete checklist.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
📝 Coding Plan
  • Generate coding plan for human review comments

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Tip

CodeRabbit can enforce grammar and style rules using `languagetool`.

Configure the reviews.tools.languagetool setting to enable/disable rules and categories. Refer to the LanguageTool Community to learn more.

Copy link
Copy Markdown

@cubic-dev-ai cubic-dev-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 1 file


Since this is your first cubic review, here's how it works:

  • cubic automatically reviews your code and comments on bugs and improvements
  • Teach cubic by replying to its comments. cubic learns from your replies and gets better over time
  • Add one-off context when rerunning by tagging @cubic-dev-ai with guidance or docs links (including llms.txt)
  • Ask questions if you need clarification on any suggestion

Double-clicking a tab title in the pane tab bar (Bonsplit) now toggles
pane zoom, maximizing that pane within the split layout. Uses the
existing onZoomToggle callback already wired through TabBarView.
@STRML STRML force-pushed the feat/double-click-tab-zoom branch from d9f21c8 to 038063e Compare March 16, 2026 18:46
@STRML STRML changed the title feat: double-click sidebar tab to toggle pane zoom feat: double-click pane tab to toggle zoom Mar 16, 2026
@lawrencecchen
Copy link
Copy Markdown
Contributor

Conflicted on this since we we might want to make double click "rename workspace/tab" instead... maybe we can have a button for maximizing next to the X that only appears on hover?

@STRML
Copy link
Copy Markdown
Author

STRML commented Mar 16, 2026

Conflicted on this since we we might want to make double click "rename workspace/tab" instead... maybe we can have a button for maximizing next to the X that only appears on hover?

I would suggest that full screen toggle on double click makes more sense - it is the pattern in many other apps. Since you have to type to rename a tab, the cmd+R shortcut seems more convenient.

That said, a single click and hover on the tab title is not a bad way to also pop a rename in-place, like renaming in Word or in most file explorers.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants