Tighten browser import sheet UI#1593
Tighten browser import sheet UI#1593lawrencecchen merged 9 commits intotask-browser-import-followupsfrom
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
Your free trial has ended. If you'd like to continue receiving code reviews, you can add a payment method here.
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
📝 Coding Plan
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
There was a problem hiding this comment.
1 issue found across 2 files (changes from recent commits).
Prompt for AI agents (unresolved issues)
Check if these issues are valid — if so, understand the root cause of each and fix them. If appropriate, use sub-agents to investigate and fix each issue separately.
<file name="cmuxUITests/BrowserImportProfilesUITests.swift">
<violation number="1" location="cmuxUITests/BrowserImportProfilesUITests.swift:155">
P2: The wizard-open poll can return too early because it uses `||` with window existence, but callers immediately click `Next`. Wait for the Next button itself to avoid UI-test race flakiness.</violation>
</file>
Reply with feedback, questions, or to request a fix. Tag @cubic-dev-ai to re-run a review.
| "Expected the import wizard to open" | ||
| ) | ||
| let wizardOpened = browserImportPollUntil(timeout: 5.0) { | ||
| app.buttons["Next"].exists || app.windows["Import Browser Data"].exists |
There was a problem hiding this comment.
P2: The wizard-open poll can return too early because it uses || with window existence, but callers immediately click Next. Wait for the Next button itself to avoid UI-test race flakiness.
Prompt for AI agents
Check if this issue is valid — if so, understand the root cause and fix it. At cmuxUITests/BrowserImportProfilesUITests.swift, line 155:
<comment>The wizard-open poll can return too early because it uses `||` with window existence, but callers immediately click `Next`. Wait for the Next button itself to avoid UI-test race flakiness.</comment>
<file context>
@@ -151,10 +151,10 @@ final class BrowserImportProfilesUITests: XCTestCase {
- "Expected the import wizard to open"
- )
+ let wizardOpened = browserImportPollUntil(timeout: 5.0) {
+ app.buttons["Next"].exists || app.windows["Import Browser Data"].exists
+ }
+ XCTAssertTrue(wizardOpened, "Expected the import wizard to open")
</file context>
| app.buttons["Next"].exists || app.windows["Import Browser Data"].exists | |
| app.buttons["Next"].exists |
lawrencecchen
merged commit 7f589bf
into
task-browser-import-followups
There was a problem hiding this comment.
1 issue found across 6 files (changes from recent commits).
Prompt for AI agents (unresolved issues)
Check if these issues are valid — if so, understand the root cause of each and fix them. If appropriate, use sub-agents to investigate and fix each issue separately.
<file name="Sources/cmuxApp.swift">
<violation number="1" location="Sources/cmuxApp.swift:2017">
P2: Add the new browser profile popover debug window identifier to `cmuxAuxiliaryWindowIdentifiers`; otherwise Cmd+W/menu Close can target workspace/panel closing instead of this auxiliary debug window.</violation>
</file>
Reply with feedback, questions, or to request a fix. Tag @cubic-dev-ai to re-run a review.
| window.titlebarAppearsTransparent = false | ||
| window.isMovableByWindowBackground = true | ||
| window.isReleasedWhenClosed = false | ||
| window.identifier = NSUserInterfaceItemIdentifier("cmux.browserProfilePopoverDebug") |
There was a problem hiding this comment.
P2: Add the new browser profile popover debug window identifier to cmuxAuxiliaryWindowIdentifiers; otherwise Cmd+W/menu Close can target workspace/panel closing instead of this auxiliary debug window.
Prompt for AI agents
Check if this issue is valid — if so, understand the root cause and fix it. At Sources/cmuxApp.swift, line 2017:
<comment>Add the new browser profile popover debug window identifier to `cmuxAuxiliaryWindowIdentifiers`; otherwise Cmd+W/menu Close can target workspace/panel closing instead of this auxiliary debug window.</comment>
<file context>
@@ -1949,6 +1996,205 @@ private final class BrowserImportHintDebugWindowController: NSWindowController,
+ window.titlebarAppearsTransparent = false
+ window.isMovableByWindowBackground = true
+ window.isReleasedWhenClosed = false
+ window.identifier = NSUserInterfaceItemIdentifier("cmux.browserProfilePopoverDebug")
+ window.center()
+ window.contentView = NSHostingView(rootView: BrowserProfilePopoverDebugView())
</file context>
…ort-minimal-ui Tighten browser import sheet UI
1 participant
Summary
Testing
Issues
Summary by cubic
Shrink the browser import sheet, add lighter blank‑tab import hints (inline strip, floating card, toolbar chip), and defer menu‑triggered dialog presentation to remove flakiness. Settings now deep‑link to the import controls; copy/layout are tighter, new debug controls tune toolbar spacing and profile popover padding, and tests are stabilized.
Refactors
Bug Fixes
.browserImportdeep link.Written for commit c4742a4. Summary will update on new commits.