Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

38056 updates #38694

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

Conversation

warunawickramasingha
Copy link
Contributor

@warunawickramasingha warunawickramasingha commented Jan 24, 2025

Description of work

Update manual testing instructions for the slice viewer

Fixes #38056
Fixes #38649.

Test instructions

1- The dev-docs-html target should build without any error/warings.
2- Open the index.html from \build\dev-docs\html
3- Search for the SliceViewer Testing and follow the updated test instructions listed in the below issues.
#38056
#38649.
4- The updated test instructions above should reflect the real observations.

Note: No unit test or release notes were added since its just an update to test documentation.


Reviewer

Please comment on the points listed below (full description).
Your comments will be used as part of the gatekeeper process, so please comment clearly on what you have checked during your review. If changes are made to the PR during the review process then your final comment will be the most important for gatekeepers. In this comment you should make it clear why any earlier review is still valid, or confirm that all requested changes have been addressed.

Code Review

  • Is the code of an acceptable quality?
  • Does the code conform to the coding standards?
  • Are the unit tests small and test the class in isolation?
  • If there is GUI work does it follow the GUI standards?
  • If there are changes in the release notes then do they describe the changes appropriately?
  • Do the release notes conform to the release notes guide?

Functional Tests

  • Do changes function as described? Add comments below that describe the tests performed?
  • Do the changes handle unexpected situations, e.g. bad input?
  • Has the relevant (user and developer) documentation been added/updated?

Does everything look good? Mark the review as Approve. A member of @mantidproject/gatekeepers will take care of it.

Gatekeeper

If you need to request changes to a PR then please add a comment and set the review status to "Request changes". This will stop the PR from showing up in the list for other gatekeepers.

@sf1919 sf1919 added this to the Release 6.13 milestone Jan 27, 2025
@warunawickramasingha warunawickramasingha added the Documentation Issues and pull requests related to documentation label Jan 27, 2025
Copy link
Contributor

@RichardWaiteSTFC RichardWaiteSTFC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks for collating and fixing these issues! Just a small thing about the screenshot, but otherwise looks great thanks!

@RichardWaiteSTFC RichardWaiteSTFC self-assigned this Jan 27, 2025
@warunawickramasingha
Copy link
Contributor Author

Looks good, thanks for collating and fixing these issues! Just a small thing about the screenshot, but otherwise looks great thanks!

Thanks for taking a look. Can you please specify which screenshot needs updating(as there are 2 in the PR) and what is the change required?
Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Documentation Issues and pull requests related to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update sliceviewer manual testing instructions Update test instructions in SliceViewer
3 participants