-
Notifications
You must be signed in to change notification settings - Fork 126
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
38056 updates #38694
base: main
Are you sure you want to change the base?
38056 updates #38694
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, thanks for collating and fixing these issues! Just a small thing about the screenshot, but otherwise looks great thanks!
Thanks for taking a look. Can you please specify which screenshot needs updating(as there are 2 in the PR) and what is the change required? |
Description of work
Update manual testing instructions for the slice viewer
Fixes #38056
Fixes #38649.
Test instructions
1- The
dev-docs-html
target should build without any error/warings.2- Open the
index.html
from \build\dev-docs\html3- Search for the
SliceViewer Testing
and follow the updated test instructions listed in the below issues.#38056
#38649.
4- The updated test instructions above should reflect the real observations.
Note: No unit test or release notes were added since its just an update to test documentation.
Reviewer
Please comment on the points listed below (full description).
Your comments will be used as part of the gatekeeper process, so please comment clearly on what you have checked during your review. If changes are made to the PR during the review process then your final comment will be the most important for gatekeepers. In this comment you should make it clear why any earlier review is still valid, or confirm that all requested changes have been addressed.
Code Review
Functional Tests
Does everything look good? Mark the review as Approve. A member of
@mantidproject/gatekeepers
will take care of it.Gatekeeper
If you need to request changes to a PR then please add a comment and set the review status to "Request changes". This will stop the PR from showing up in the list for other gatekeepers.