Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

38056 updates #38694

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from 3 commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 10 additions & 4 deletions dev-docs/source/Testing/SliceViewer/SliceViewer.rst
Original file line number Diff line number Diff line change
Expand Up @@ -85,7 +85,7 @@ Do the following tests with an EventWorkspace (e.g. ``CNCS_7860_event.nxs``) and

a. Confirm it tracks with the cursor when Track Cursor is checked
b. Uncheck the track cursor and confirm it updates when the cursor is clicked.
c. Transpose the axes (as in step 6) and confirm the cursor position displayed is still correct (note if Track Cursor is checked you will need to click on the colorfill plot again).
c. Transpose the axes (as in step 6) and click on the colorfill plot. Confirm the clicked cursor position is correctly displayed in the table. If Track Cursor is checked, the table should still track the cursor correctly.

8. Resize the sliceviewer window, check the widgets, buttons etc. are still visible and clear for reasonable aspect ratios.

Expand Down Expand Up @@ -190,7 +190,7 @@ Test the :ref:`Peak Overlay<mantid:sliceviewer_peaks_overlay>`

3. Double click a row

- It should change the slicepoint along the integrated momentum axis and zoom into the peak - e.g. in (X,Y) = (H,K) then the slicepoint along L will be set to 1 and there will be a cross at (0,0).
- It should change the slicepoint along the integrated momentum axis and zoom into the peak - e.g. When double clicked on the row with HKL = (1,0,1) or HKL = (1,0,0) the slicepoint along L will be set to 1 or 0 respectively, and there will be a cross at (X,Y) = (H,K) = (1,0) in both cases.
- Note for ``md_4D`` a peak will not be plotted if a non-Q axis is viewed, if both axes are Q-dimensions then the cross should be plotted at all E (obviously a Bragg peak will only be on the elastic line but the peak object has no elastic/inelastic logic and the sliceviewer only knows that `E` is not a momentum axis, it could be temperature etc.).

4. Click Add Peaks in the Peak Actions section at the top of the peak viewer (note for 4D workspaces the peak overlay won't work for non_Q dimensions).
Expand Down Expand Up @@ -333,7 +333,7 @@ It should only be enabled for the `ws_3D` and `ws_3D_QLab` workspaces (see comme
21. Increase the thickness by dragging the left red marker of the cut representation to encompass the peak in the data - check the peak appears in the 1D plot at the right thickness.
22. Play around with the direction of the cut by dragging the white markers at the end points of the white line - the vectors u1 and u3 should be orthogonal unit vectors.
23. Reset the cut by transposing the axes so (X,Y) = (L,K)
24. Double the slice thickness along H from 0.1 -> 0.2 (the counts of the peak in the 1D plot should double from ~2000 -> ~4000)
24. Double the slice thickness along H from 0.1 -> 0.2 (the counts of the peak in the 1D plot should double from ~1750 -> ~3500)
25. Change c* of u1 from 1 -> -1

- The peak in the 1D plot should move from x= 1 -> -1
Expand All @@ -343,7 +343,13 @@ It should only be enabled for the `ws_3D` and `ws_3D_QLab` workspaces (see comme

- Check that the table values are updated correctly (use the HKL in the cursor info table to help determine this)

27. Produce a non-axis aligned cut where the peak is not in the center of the x-range. Take the x-value at the peak maximum and plug it into the axis label - it should produce the HKL of the peak (0,0,1).
27. Produce a non-axis aligned cut as shown below where the peak is not in the center of the x-range. Take the x-value at the peak maximum and plug it into the axis label - it should produce the HKL of the peak (0,0,1).

- In the example below, the x axis label is ``(0.0, -0.43+0.88x, 0.78+0.48x) in 6.53 Ang^-1``. By replacing x-value with the peak maximum of ~ 0.5, we get ``(0.0, -0.43+0.88*0.5, 0.78+0.48*0.5)`` = ``(0.0,0.01,1.02)`` which is very close actual peak HKL = ``(0,0,1)``

.. figure:: ../../images/SliceViewer/CutViewer_nonAxisAlignedCut.png
warunawickramasingha marked this conversation as resolved.
Show resolved Hide resolved
:class: screenshot
:align: center

Specific Tests
--------------
Expand Down
Binary file modified dev-docs/source/images/SliceViewer/CutViewer_KLplane.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading