243-fix-crash-when-no-location-permission #244
Conversation
JulianBissekkou
changed the title
| @@ -28,7 +28,7 @@ class MaplibreMap extends StatefulWidget { | |||
| this.trackCameraPosition = false, | |||
| this.myLocationEnabled = false, | |||
| this.myLocationTrackingMode = MyLocationTrackingMode.None, | |||
| this.myLocationRenderMode = MyLocationRenderMode.COMPASS, | |||
| this.myLocationRenderMode = MyLocationRenderMode.NORMAL, | |||
There was a problem hiding this comment.
I think this is a good approach, but we should note this in the release notes, since it's a breaking change.
There was a problem hiding this comment.
PR for changelog docs: #247
There was a problem hiding this comment.
Thanks for writing the changelog for me :)
There was a problem hiding this comment.
Should I adjust the documentation to highlight that you only need location permission if you use specific properties?
| @@ -55,7 +55,13 @@ class MaplibreMap extends StatefulWidget { | |||
| ], | |||
| this.useDelayedDisposal, | |||
| this.useHybridCompositionOverride, | |||
| }) : assert(annotationOrder.length <= 4), | |||
| }) : assert( | |||
|
@m0nac0 |
|
I can check it out but i dont have any rights so can't do a lot. m0nac0 is sometimes inactive but he will come back, i recommend to create a fork with the modification you need for temporary purposes |
|
@m0nac0 Can you check so we can merge this sometime? |
…243-fix-crash-when-no-location-permission # Conflicts: # example/ios/Podfile.lock # example/lib/main.dart # example/lib/page.dart
|
Sorry you had to wait with this PR... LGTM, could you update the base branch? Then it should be merged automatically. |
depends on #244 --------- Co-authored-by: Julian Bissekkou <[email protected]>
This fixes maplibre#243. --------- Co-authored-by: Julian Bissekkou <[email protected]>
depends on maplibre#244 --------- Co-authored-by: Julian Bissekkou <[email protected]>
This fixes #243.