-
Notifications
You must be signed in to change notification settings - Fork 110
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
243-fix-crash-when-no-location-permission #244
Merged
m0nac0
merged 5 commits into
maplibre:main
from
tappeddev:243-fix-crash-when-no-location-permission
Jun 30, 2023
Merged
Changes from all commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
cd90b2a
add assertions for properties that require location permission
JulianBissekkou 03b2fdb
Merge branch 'main' into 243-fix-crash-when-no-location-permission
JulianBissekkou 3c2b5d2
Merge branch 'main' of github.com:tappeddev/flutter-maplibre-gl into …
JulianBissekkou c72d11d
fix lint warnings
JulianBissekkou 5947a5b
Merge branch 'main' into 243-fix-crash-when-no-location-permission
JulianBissekkou File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,61 @@ | ||
import 'package:flutter/material.dart'; | ||
import 'package:maplibre_gl/mapbox_gl.dart'; | ||
|
||
import 'page.dart'; | ||
|
||
class NoLocationPermissionPage extends ExamplePage { | ||
const NoLocationPermissionPage({super.key}) | ||
: super( | ||
const Icon(Icons.gps_off), | ||
'Using a map without user location/permission', | ||
needsLocationPermission: false, | ||
); | ||
|
||
@override | ||
Widget build(BuildContext context) { | ||
return const NoLocationPermissionBody(); | ||
} | ||
} | ||
|
||
class NoLocationPermissionBody extends StatefulWidget { | ||
const NoLocationPermissionBody({super.key}); | ||
|
||
@override | ||
State<NoLocationPermissionBody> createState() => | ||
_NoLocationPermissionBodyState(); | ||
} | ||
|
||
class _NoLocationPermissionBodyState extends State<NoLocationPermissionBody> { | ||
@override | ||
Widget build(BuildContext context) { | ||
return MaplibreMap( | ||
initialCameraPosition: const CameraPosition( | ||
target: LatLng(-33.852, 151.211), | ||
zoom: 11.0, | ||
), | ||
styleString: '''{ | ||
"version": 8, | ||
"sources": { | ||
"OSM": { | ||
"type": "raster", | ||
"tiles": [ | ||
"https://a.tile.openstreetmap.org/{z}/{x}/{y}.png", | ||
"https://b.tile.openstreetmap.org/{z}/{x}/{y}.png", | ||
"https://c.tile.openstreetmap.org/{z}/{x}/{y}.png" | ||
], | ||
"tileSize": 256, | ||
"attribution": "© OpenStreetMap contributors", | ||
"maxzoom": 18 | ||
} | ||
}, | ||
"layers": [ | ||
{ | ||
"id": "OSM-layer", | ||
"source": "OSM", | ||
"type": "raster" | ||
} | ||
] | ||
}''', | ||
); | ||
} | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -28,7 +28,7 @@ class MaplibreMap extends StatefulWidget { | |
this.trackCameraPosition = false, | ||
this.myLocationEnabled = false, | ||
this.myLocationTrackingMode = MyLocationTrackingMode.None, | ||
this.myLocationRenderMode = MyLocationRenderMode.COMPASS, | ||
this.myLocationRenderMode = MyLocationRenderMode.NORMAL, | ||
this.logoViewMargins, | ||
this.compassViewPosition, | ||
this.compassViewMargins, | ||
|
@@ -55,7 +55,13 @@ class MaplibreMap extends StatefulWidget { | |
], | ||
this.useDelayedDisposal, | ||
this.useHybridCompositionOverride, | ||
}) : assert(annotationOrder.length <= 4), | ||
}) : assert( | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Good idea! |
||
myLocationRenderMode != MyLocationRenderMode.NORMAL | ||
? myLocationEnabled | ||
: true, | ||
"$myLocationRenderMode requires [myLocationEnabled] set to true.", | ||
), | ||
assert(annotationOrder.length <= 4), | ||
assert(annotationConsumeTapEvents.length > 0), | ||
super(key: key); | ||
|
||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this is a good approach, but we should note this in the release notes, since it's a breaking change.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
PR for changelog docs: #247
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for writing the changelog for me :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should I adjust the documentation to highlight that you only need location permission if you use specific properties?