Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat!: migrate maplibre-native for android to version 11.0.0 (take 2) #406

Merged
merged 4 commits into from
Jun 5, 2024

Conversation

josxha
Copy link
Collaborator

@josxha josxha commented May 16, 2024

This pull request updates the package to use version 11.0.0 of maplibre-native for android. It superseeds #403 to make it not dependant on other pull requests.

If wanted, we can change the occurences of "Maplibre" to "MapLibre" to be more in line with maplibre-native. (I'd prefer to do it in a follow-up pr tho).

@josxha josxha changed the title feat!: migrate maplibre-native for android to version 11.0.0 (take 2) feat!: migrate maplibre-native for android to version 11.0.0 (take 2) May 16, 2024
@josxha josxha changed the title feat!: migrate maplibre-native for android to version 11.0.0 (take 2) feat!: migrate maplibre-native for android to version 11.0.0 (take 2) May 16, 2024
@josxha josxha self-assigned this May 20, 2024
@josxha josxha added this to the v0.20.0 milestone May 20, 2024
@josxha josxha marked this pull request as draft May 31, 2024 05:02
@josxha josxha force-pushed the feature/android-maplibre-11 branch from 08da679 to fd89483 Compare June 4, 2024 12:50
android/build.gradle Outdated Show resolved Hide resolved
@josxha josxha marked this pull request as ready for review June 4, 2024 15:08
@josxha
Copy link
Collaborator Author

josxha commented Jun 4, 2024

Fixed the version of the MapLibre plugins.
There are newer versions for androidx.core:core-ktx too. Should we update it or is it better to keep it on an older version?

@kuhnroyal
Copy link
Collaborator

We can do that separately.

@kuhnroyal
Copy link
Collaborator

Sadly I only get black views instead of maps, something is wrong, not sure what.

@josxha
Copy link
Collaborator Author

josxha commented Jun 5, 2024

That's strange. It works fine for me on an physical device with android 11.
What android version were you testing on?

@kuhnroyal
Copy link
Collaborator

Only simulator so far, but the main branch works on simulator.

@josxha
Copy link
Collaborator Author

josxha commented Jun 5, 2024

Could you check what android or sdk version it's using? Maybe it's related or similar to #327 which depends on the used OS version.

@kuhnroyal
Copy link
Collaborator

Dunno why but it is working now :)

@kuhnroyal
Copy link
Collaborator

And also works on device.
I have not reviewed code yet, only tested.

@josxha
Copy link
Collaborator Author

josxha commented Jun 5, 2024

Dunno why but it is working now :)

Awesome!👍

Copy link
Collaborator

@kuhnroyal kuhnroyal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks pretty straight forward, nothing to add :)

@josxha josxha merged commit f3a7d2d into maplibre:main Jun 5, 2024
9 checks passed
@josxha
Copy link
Collaborator Author

josxha commented Jun 5, 2024

Thanks again for the help on this pr! (:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants