Fix broadcast model switching: skip /model when model names are empty#3
Open
jsell-rh wants to merge 1 commit intomarkturansky:mainfrom
Open
Fix broadcast model switching: skip /model when model names are empty#3jsell-rh wants to merge 1 commit intomarkturansky:mainfrom
jsell-rh wants to merge 1 commit intomarkturansky:mainfrom
Conversation
…are empty The callers of BroadcastCheckIn and SingleAgentCheckIn always pass empty strings for checkModel and workModel, causing '/model ' (with no model name) to be sent to agents. This resulted in broken model switch attempts that would time out or fail. Now when checkModel/workModel are empty, the model switch steps are skipped entirely and the check-in runs on whatever model the agent is already using. Model economy still works if actual model names are passed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
/modelwas sent with an empty model name, causing timeoutscheckModel/workModelare empty strings (which is always the case currently), the/modelcommands are now skipped entirelyChanges
internal/coordinator/tmux.go: Wrap model switch and restore steps inif checkModel != ""/if workModel != ""guards inrunAgentCheckIn()Testing
-race