Skip to content

Fix broadcast model switching: skip /model when model names are empty #3

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
jsell-rh wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fix broadcast model switching: skip /model when model names are empty #3

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
53 changes: 30 additions & 23 deletions internal/coordinator/tmux.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -336,22 +336,26 @@ func (s *Server) runAgentCheckIn(spaceName, canonical, tmuxSession, checkModel,
s.broadcastProgress(spaceName, canonical+": "+msg)
}

progress("switching to " + checkModel)
if err := tmuxSendKeys(tmuxSession, "/model "+checkModel); err != nil {
result.addError(canonical + ": model switch failed: " + err.Error())
return
}
// Model economy: switch to a lightweight model for check-ins if configured.
// If checkModel is empty, skip model switching entirely.
if checkModel != "" {
progress("switching to " + checkModel)
if err := tmuxSendKeys(tmuxSession, "/model "+checkModel); err != nil {
result.addError(canonical + ": model switch failed: " + err.Error())
return
}

progress("waiting for model switch...")
if err := waitForIdle(tmuxSession, idlePollTimeout); err != nil {
result.addError(canonical + ": model switch did not complete: " + err.Error())
return
progress("waiting for model switch...")
if err := waitForIdle(tmuxSession, idlePollTimeout); err != nil {
result.addError(canonical + ": model switch did not complete: " + err.Error())
return
}
}

boardTimeBefore := s.agentUpdatedAt(spaceName, canonical)

progress("sending /boss-check prompt")
if err := tmuxSendKeys(tmuxSession, "/boss-check "+canonical+" "+spaceName); err != nil {
progress("sending /boss.check prompt")
if err := tmuxSendKeys(tmuxSession, "/boss.check "+canonical+" "+spaceName); err != nil {
result.addError(canonical + ": check-in send failed: " + err.Error())
return
}
Expand All @@ -364,20 +368,23 @@ func (s *Server) runAgentCheckIn(spaceName, canonical, tmuxSession, checkModel,
result.addSent(canonical)
progress("board post received")

progress("waiting for idle before model restore...")
if err := waitForIdle(tmuxSession, idlePollTimeout); err != nil {
result.addError(canonical + ": post-checkin idle wait failed: " + err.Error())
}
// Restore the working model if one was specified
if workModel != "" {
progress("waiting for idle before model restore...")
if err := waitForIdle(tmuxSession, idlePollTimeout); err != nil {
result.addError(canonical + ": post-checkin idle wait failed: " + err.Error())
}

progress("restoring " + workModel)
if err := tmuxSendKeys(tmuxSession, "/model "+workModel); err != nil {
result.addError(canonical + ": model restore failed: " + err.Error())
return
}
progress("restoring " + workModel)
if err := tmuxSendKeys(tmuxSession, "/model "+workModel); err != nil {
result.addError(canonical + ": model restore failed: " + err.Error())
return
}

progress("waiting for model restore...")
if err := waitForIdle(tmuxSession, idlePollTimeout); err != nil {
result.addError(canonical + ": model restore did not complete: " + err.Error())
progress("waiting for model restore...")
if err := waitForIdle(tmuxSession, idlePollTimeout); err != nil {
result.addError(canonical + ": model restore did not complete: " + err.Error())
}
}

progress("complete")
Expand Down