Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a universal function to replace subgraph in OptimizationRule #3353

Open
wants to merge 8 commits into
base: master
Choose a base branch
from
Open

Add a universal function to replace subgraph in OptimizationRule #3353

wants to merge 8 commits into from

Conversation

ericpai
Copy link
Contributor

@ericpai ericpai commented Jun 27, 2023 •
edited
Loading

This PR adds a univeral function replace_subgraph to OptimizationRule for later use. The unit test cases are added as well.

Fixes #3352

Check code requirements

  • tests added / passed (if needed)
  • Ensure all linting tests pass, see here for how to run them

@ericpai ericpai force-pushed the refine/subgraph branch 2 times, most recently from b9e6430 to 12525c0 Compare June 27, 2023 09:33
@ericpai ericpai marked this pull request as ready for review June 27, 2023 09:41
@ericpai ericpai requested a review from a team as a code owner June 27, 2023 09:41
wjsi
wjsi reviewed Jun 27, 2023
View reviewed changes
mars/optimization/logical/core.py Outdated Show resolved Hide resolved
mars/optimization/logical/core.py Outdated Show resolved Hide resolved
mars/optimization/logical/core.py Outdated Show resolved Hide resolved
wjsi
wjsi previously approved these changes Jun 28, 2023
View reviewed changes
Copy link
Member

@wjsi wjsi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Seems errors are not relevant.

@ericpai ericpai force-pushed the refine/subgraph branch from e060abf to 8505806 Compare July 3, 2023 05:15
wjsi
wjsi reviewed Jul 3, 2023
View reviewed changes
Copy link
Member

@wjsi wjsi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

wjsi
wjsi approved these changes Sep 1, 2023
View reviewed changes
Copy link
Member

@wjsi wjsi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

chaokunyang
chaokunyang approved these changes Sep 1, 2023
View reviewed changes
Copy link
Contributor

@chaokunyang chaokunyang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chaokunyang chaokunyang chaokunyang approved these changes

@wjsi wjsi wjsi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

A more universal function to replace subgraph in OptimizationRule
3 participants
@ericpai @wjsi @chaokunyang