Skip to content

docs(mapgen-studio-no-hardcoded-defaults): mark all tasks as executed #1627

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mateicanavra merged 1 commit into from
Jun 12, 2026
Merged

docs(mapgen-studio-no-hardcoded-defaults): mark all tasks as executed #1627

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions openspec/changes/mapgen-studio-no-hardcoded-defaults/tasks.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,14 +1,14 @@
## 1. Implementation

- [ ] 1.1 Delete `apps/mapgen-studio/src/ui/data/defaultConfig.ts`; confirm no
- [x] 1.1 Delete `apps/mapgen-studio/src/ui/data/defaultConfig.ts`; confirm no
remaining importers (app or tests) besides the retargeted shape tests.
- [ ] 1.2 Rewrite the two legacy-shape blocks in
- [x] 1.2 Rewrite the two legacy-shape blocks in
`test/config/defaultConfigSchema.test.ts` to assert against
`STANDARD_RECIPE_CONFIG`, preserving the semantic-surface guards
(expected key sets, no raw op envelopes, no legacy stage keys).

## 2. Verification

- [ ] 2.1 `bun run openspec -- validate mapgen-studio-no-hardcoded-defaults --strict`
- [ ] 2.2 tsc + mapgen-studio vitest green
- [ ] 2.3 `rg` sweep: no app-side literal pipeline-default duplicates remain.
- [x] 2.1 `bun run openspec -- validate mapgen-studio-no-hardcoded-defaults --strict`
- [x] 2.2 tsc + mapgen-studio vitest green
- [x] 2.3 `rg` sweep: no app-side literal pipeline-default duplicates remain.