Skip to content

docs(mapgen-studio-no-hardcoded-defaults): mark all tasks as executed#1627

Merged
mateicanavra merged 1 commit into
mainfrom
design/no-hardcoded-defaults
Jun 12, 2026
Merged

docs(mapgen-studio-no-hardcoded-defaults): mark all tasks as executed#1627
mateicanavra merged 1 commit into
mainfrom
design/no-hardcoded-defaults

Conversation

@mateicanavra

Copy link
Copy Markdown
Owner

All implementation and verification tasks for the mapgen-studio-no-hardcoded-defaults change have been completed:

  • Deleted defaultConfig.ts and confirmed no remaining importers outside the retargeted shape tests
  • Rewrote the legacy-shape test blocks in defaultConfigSchema.test.ts to assert against STANDARD_RECIPE_CONFIG, preserving semantic-surface guards
  • Passed strict OpenSpec validation, tsc, and mapgen-studio vitest
  • Confirmed via rg sweep that no app-side literal pipeline-default duplicates remain

This was referenced Jun 12, 2026
@github-actions

Copy link
Copy Markdown

Railway preview (MapGen Studio): not provisioned for this PR.

Policy (Graphite stacks): previews are created only for the top-of-stack PR by default.

  • To force a preview for this PR: add label railway-preview
  • To suppress a preview: add label no-railway-preview

Debug: {"isClosed":false,"isFork":false,"suppress":false,"force":false,"isTopOfStack":false,"hasToken":true,"draft":false}

mateicanavra commented Jun 12, 2026

Copy link
Copy Markdown
Owner Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

mateicanavra commented Jun 12, 2026

Copy link
Copy Markdown
Owner Author

Merge activity

  • Jun 12, 8:50 PM UTC: A user started a stack merge that includes this pull request via Graphite.
  • Jun 12, 9:37 PM UTC: Graphite rebased this pull request as part of a merge.
  • Jun 12, 9:37 PM UTC: @mateicanavra merged this pull request with Graphite.

@mateicanavra
mateicanavra changed the base branch from design/spacing-substrate to graphite-base/1627 June 12, 2026 21:34
@mateicanavra
mateicanavra changed the base branch from graphite-base/1627 to main June 12, 2026 21:35
…ate (no-hardcoded-overrides law)

src/ui/data/defaultConfig.ts was a 330-line literal copy of the standard
recipe's default pipeline config that the app never imported (defaults
flow from the generated STANDARD_RECIPE_CONFIG artifact via
buildDefaultConfig). Its only consumers were two shape-guard test blocks,
now retargeted at the artifact — which exposed real drift: the hand copy
never tracked the ecology pedology/features config groups.

144 tests + tsc green.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
@mateicanavra
mateicanavra force-pushed the design/no-hardcoded-defaults branch from 5c5cd1e to 49c148e Compare June 12, 2026 21:36
@mateicanavra
mateicanavra merged commit 8c7e9e6 into main Jun 12, 2026
This was referenced Jun 12, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant