Skip to content

Commit

Permalink
[DEV-17076] Change translation key for Tour_AddWebsite and also the e…
Browse files Browse the repository at this point in the history
…nglish translation (#21146)

* Change translation key for Tour_AddWebsite and also the english translation

* UI tests: fixed UI test failure due to wording change Add Website -> Add Another Website

* Integration tests: updated expected outcome with new text

* UI tests: fix mobile menu test due to new text Add another website

* Updated UI test screenshots

* Update UI test screenshot

---------

Co-authored-by: Ben <[email protected]>
  • Loading branch information
caddoo and bx80 committed Aug 18, 2023
1 parent 2526754 commit fd02bdd
Show file tree
Hide file tree
Showing 14 changed files with 20 additions and 20 deletions.
2 changes: 1 addition & 1 deletion plugins/Tour/Engagement/ChallengeAddedWebsite.php
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@ public function __construct(DataFinder $dataFinder)

public function getName()
{
return Piwik::translate('Tour_AddWebsite');
return Piwik::translate('Tour_AddAnotherWebsite');
}

public function getDescription()
Expand Down
2 changes: 1 addition & 1 deletion plugins/Tour/lang/en.json
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
"Engagement": "Engagement",
"UploadLogo": "Upload your logo",
"InviteUser": "Invite a user",
"AddWebsite": "Add a website",
"AddAnotherWebsite": "Add another website",
"AddReport": "Add a scheduled report",
"AddSegment": "Add a segment",
"AddAnnotation": "Add an annotation",
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@
</row>
<row>
<id>add_website</id>
<name>Add a website</name>
<name>Add another website</name>
<description>Websites management lets you add a new website and edit existing websites.</description>
<isCompleted>0</isCompleted>
<isSkipped>0</isSkipped>
Expand Down
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@
</row>
<row>
<id>add_website</id>
<name>Add a website</name>
<name>Add another website</name>
<description>Websites management lets you add a new website and edit existing websites.</description>
<isCompleted>0</isCompleted>
<isSkipped>0</isSkipped>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@
</row>
<row>
<id>add_website</id>
<name>Add a website</name>
<name>Add another website</name>
<description>Websites management lets you add a new website and edit existing websites.</description>
<isCompleted>1</isCompleted>
<isSkipped>0</isSkipped>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@
</row>
<row>
<id>add_website</id>
<name>Add a website</name>
<name>Add another website</name>
<description>Websites management lets you add a new website and edit existing websites.</description>
<isCompleted>1</isCompleted>
<isSkipped>0</isSkipped>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@
</row>
<row>
<id>add_website</id>
<name>Add a website</name>
<name>Add another website</name>
<description>Websites management lets you add a new website and edit existing websites.</description>
<isCompleted>0</isCompleted>
<isSkipped>0</isSkipped>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@
</row>
<row>
<id>add_website</id>
<name>Add a website</name>
<name>Add another website</name>
<description>Websites management lets you add a new website and edit existing websites.</description>
<isCompleted>0</isCompleted>
<isSkipped>0</isSkipped>
Expand Down
4 changes: 2 additions & 2 deletions tests/UI/expected-screenshots/Menus_mobile_left.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.

0 comments on commit fd02bdd

Please sign in to comment.