Update the font cache buster parameter #20945
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bx80
added
Task
michalkleiner
approved these changes
Jun 28, 2023
|
Related documentation update PR |
|
Looks fine. Do we also need this change for 4.x-dev, guess the font had been adjusted there as well? |
|
Also I was wondering if we should maybe write a quick github action, that checks if the font files are updated in a PR and if so parses the icons.css to check if the parameter was updated as well? |
11 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Recent changes have added new glyphs to the Matomo icon font, this PR updates the cache buster parameter in the icons stylesheet to invalidate any browser font caching and make sure the updated font is used.
Review