Github action to check that the font cachebuster was updated #20973
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… when the font file is changed
bx80
added
c: Tests & QA
bx80
added
Needs Review
11 tasks
sgiehl
requested changes
Jul 7, 2023
sgiehl
force-pushed
the
github-action-font-check
branch
9 times, most recently
from
f9cad92
to
529b5fa
Compare
|
I've slightly updated the action, so the error will be shown as inline annotation:
|
sgiehl
force-pushed
the
github-action-font-check
branch
from
529b5fa
to
3164b88
Compare
sgiehl
approved these changes
Jul 10, 2023
sgiehl
added
the
not-in-changelog
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Fixes #20991
This is a simple github action to check that the font cachebuster parameter was updated whenever the Matomo font file has changed. It's pretty basic implementation using sed and wget.
If the font has been updated then it will compare the Matomo font URL line from the icons stylesheet in the PR branch against the base branch, if they are the same (ie. not updated) then the check will fail.
Review