Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update notifications and info boxes styles for accessibility #21077

Merged
merged 35 commits into from
Aug 16, 2023

Conversation

bx80
Copy link
Contributor

@bx80 bx80 commented Jul 28, 2023

Description:

Fixes #20691

The PR updates the styling of notifications and info boxes throughout the application to improve accessibility.

For some reason we have components for both notifications and alerts, each of which can be of the types: success, info, warning or error. The only real difference I can see is that notifications can optionally have a close button. There seems to be roughly equal usage of both components throughout the application. If there is no other difference then we might want consider deprecating alerts at some point in favor of notifications.

I’ve applied the new styles to both notifications and alerts and also added some notification examples to the UI demo screen so that they can be covered by UI tests.

Review

@bx80 bx80 added not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org. c: Design / UI For issues that impact Matomo's user interface or the design overall. 5.0.0 labels Jul 28, 2023
@bx80 bx80 added this to the 5.0.0 milestone Jul 28, 2023
@bx80 bx80 self-assigned this Jul 28, 2023
@michalkleiner
Copy link
Contributor

Created new ticket to look into the consolidation of the components — #21079.

@sgiehl
Copy link
Member

sgiehl commented Aug 7, 2023

@bx80 for such intense changes it's good to temporarily update the submodules to the correlating branches in the PR. That way you can directly see if all tests of the submodule plugins are passing

Copy link
Member

@sgiehl sgiehl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Had a look through all the changed screenshots. Left a couple of comments, where additional changes might be required.
Some of them might be unrelated to the purpose of this PR and could also be changed independently. In some cases the resulting screenshots aren't correct anymore and need further updates.

In general we should maybe discuss if we want to deprecate either the Notification or the Alert component. It seems they already look the same, so their is no benefit in having both.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Guess we missed that when changing the links, but guess those for authors and website should be blue, too.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've updated the marketplace .metadata CSS class to make them blue.

plugins/Morpheus/Controller.php Show resolved Hide resolved
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we maybe change this help box to look the same as an info notification?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The bottom right italic text might not work well in an info notification. Maybe there are other improvements that could be done to the report info help box at the same time so it might be worth getting some UX input on another ticket.

Copy link
Member

@sgiehl sgiehl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Had another look through the screenshots. Added a couple of comments, where screenshot changed the content unexpected, or some stuff wasn't correct.

plugins/Marketplace/stylesheets/marketplace.less Outdated Show resolved Hide resolved
plugins/Marketplace/stylesheets/marketplace.less Outdated Show resolved Hide resolved
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The placement of the dropdown icons when displayed right looks not nice. See the dashboard selector in main menu

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems okay to me, is this what you mean ?
image
There is another ticket to be done right after this one where dropdown alignment and icons will be tidied up, so maybe any tweaks to this should be done there?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

also incorrectly updated

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

here as well

tests/UI/expected-screenshots/Menus_admin_loaded.png Outdated Show resolved Hide resolved
@sgiehl sgiehl force-pushed the m20691-notification-styles branch 3 times, most recently from 505a253 to a6b10b8 Compare August 16, 2023 21:06
@sgiehl sgiehl merged commit e9b3ab1 into 5.x-dev Aug 16, 2023
3 of 5 checks passed
@sgiehl sgiehl deleted the m20691-notification-styles branch August 16, 2023 21:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c: Design / UI For issues that impact Matomo's user interface or the design overall. Needs Review PRs that need a code review not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Accessible designs for notifications & inline messages
4 participants