Skip invalidating segments for today if flag is provided #22519
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sgiehl
commented
Aug 22, 2024
Comment on lines
-911
to
-926
| if ($isYesterday) { | ||
| // Skip invalidation for yesterday if archiving for yesterday was already started after midnight in site's timezone | ||
| $invalidationsInProgress = $this->model->getInvalidationsInProgress($idSite); | ||
| $today = Date::factoryInTimezone('today', $timezone); | ||
|
|
||
| foreach ($invalidationsInProgress as $invalidation) { | ||
| if ( | ||
| $invalidation['period'] == Day::PERIOD_ID | ||
| && $date->toString() === $invalidation['date1'] | ||
| && Date::factory($invalidation['ts_started'], $timezone)->getTimestamp() >= $today->getTimestamp() | ||
| ) { | ||
| $this->logger->debug(" " . ucfirst($dateStr) . " archive already in process for idSite = $idSite, skipping invalidation..."); | ||
| return; | ||
| } | ||
| } | ||
| } |
There was a problem hiding this comment.
This check was incorrect here. On the one side it missed to check the done flag, causing any running archive to prevent a new invalidation. On the other side a running invalidation prevented any segment from being invalidated.
Therefor the check was moved to invalidateWithSegments method, where it is done for each segment separately.
caddoo
approved these changes
Aug 29, 2024
mneudert
reviewed
Sep 2, 2024
…ts-today is given
mneudert
approved these changes
Sep 2, 2024
11 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
The
core:archivecommand provides a flag--skip-segments-today, which prevents segments data from being processed for today.The currently implementation only prevents them from being processed. But invalidation done for today before archiving is started is currently done anyway. This causes also the higher periods (week, month, year) to be invalidated. But as only today is prevented from being archived for segments, those higher periods will be reprocessed anyway, even if there actually were no changes in lower periods.
To prevent this unnecessary archiving of those higher periods, this PR changes the behavior of the initial invalidation. If
--skip-segments-todayis provided, we will no longer create invalidations for segments for today (and periods including this day).This shouldn't cause any problems even if the flag is used always when archiving is triggered, as
yesterdaywill still be invalidated for segments.Review