Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ensure grouping a dimension in ms doesn't fail if ranking query limit is reached #22580

Merged
merged 1 commit into from
Sep 12, 2024
Merged

Ensure grouping a dimension in ms doesn't fail if ranking query limit is reached #22580

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions core/Columns/Dimension.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -419,6 +419,10 @@ public function groupValue($value, $idSite)
case Dimension::TYPE_BOOL:
return !empty($value) ? '1' : '0';
case Dimension::TYPE_DURATION_MS:
if (!is_numeric($value)) {
// This might happen if ranking query has too many results and `__mtm_ranking_query_others__` is returned
return $value;
}
return round($value / 1000, 2) * 1000; // because we divide we need to group them and cannot do this in formatting step
}
return $value;
Expand Down
Loading