Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure grouping a dimension in ms doesn't fail if ranking query limit is reached #22580

Merged
merged 1 commit into from
Sep 12, 2024

Conversation

sgiehl
Copy link
Member

@sgiehl sgiehl commented Sep 12, 2024

Description:

When grouping dimension values it might happen that a ranking query already limited the amount of records. In that case a row with value __mtm_ranking_query_others__ will occur.

This currently fails for dimensions in milliseconds, as calculating with the __mtm_ranking_query_others__ value doesn't work.

This PR ensures that only numeric values are taken into account for that calculation.

fixes #22579

Review

@sgiehl sgiehl added Bug For errors / faults / flaws / inconsistencies etc. Needs Review PRs that need a code review labels Sep 12, 2024
@sgiehl sgiehl added this to the 5.2.0 milestone Sep 12, 2024
@sgiehl sgiehl requested a review from a team September 12, 2024 08:10
Copy link
Contributor

@michalkleiner michalkleiner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The change looks safe.

It seems there are no tests around this, however we think the tests should be added within the CustomReports plugin to test with lower ranking limits.

@sgiehl sgiehl merged commit 5ea0c97 into 5.x-dev Sep 12, 2024
21 of 25 checks passed
@sgiehl sgiehl deleted the m22579 branch September 12, 2024 14:30
jorgeuos pushed a commit to jorgeuos/matomo that referenced this pull request Oct 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug For errors / faults / flaws / inconsistencies etc. Needs Review PRs that need a code review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] Unhandled exception processing >50,000 dimensions for custom reports
2 participants