crypto: add new CryptoStore method get_withheld_sessions_by_room_id
#5819
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
... in preparation for extracting all withheld sessions for a given room.
richvdh
requested review from
Hywan and
poljar
and removed request for
a team
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #5819 +/- ##
==========================================
- Coverage 88.55% 88.54% -0.02%
==========================================
Files 361 361
Lines 101343 101381 +38
Branches 101343 101381 +38
==========================================
+ Hits 89747 89768 +21
- Misses 7392 7408 +16
- Partials 4204 4205 +1 ☔ View full report in Codecov by Sentry. |
CodSpeed Performance ReportMerging #5819 will not alter performanceComparing Summary
|
richvdh
changed the title
CryptoStore method get_withheld_sessions_by_room_id
Implement this across all the store implementations
richvdh
force-pushed
the
rav/cryptostore_withheld_sessions_by_room_id
branch
from
a77a2c7 to
e50f5ff
Compare
integration test for the new method
richvdh
force-pushed
the
rav/cryptostore_withheld_sessions_by_room_id
branch
from
e50f5ff to
0faf3ee
Compare
poljar
approved these changes
Nov 3, 2025
Comment on lines
+1
to
+2
| CREATE INDEX "direct_withheld_info_room_id_idx" | ||
| ON "direct_withheld_info" ("room_id"); |
There was a problem hiding this comment.
Reminder to myself, this will be a merge conflict with #5817.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a new method to
CryptoStorewhich allows retrieving all the withheld sessions in a given room.Unfortunately, for indexeddb, that means a data migration, because currently the withheld sessions are indexed by
(session_id, room)rather than(room, session_id).This is groundwork for element-hq/element-meta#2876.