Skip to content

Internal: Remove unused GetStorage function on Set #162

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
turt2live merged 1 commit into from
Jun 16, 2026
Merged

Internal: Remove unused GetStorage function on Set #162

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 0 additions & 5 deletions filter/set.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -74,11 +74,6 @@ func NewSet(config *SetConfig, storage storage.PersistentStorage, pubsub pubsub.
return set, nil
}

// GetStorage - Accessor to the underlying PersistentStorage
func (s *Set) GetStorage() storage.PersistentStorage {
return s.storage
}

// CheckEvent - Checks an event over all of the set groups in order. If a set group errors, execution stops there.
// Note: the mediaDownloader may be nil to prevent parsing and downloading of media. This should only be done in test environments.
func (s *Set) CheckEvent(ctx context.Context, event gomatrixserverlib.PDU, mediaDownloader media.Downloader) (confidence.Vectors, error) {
Expand Down
2 changes: 0 additions & 2 deletions filter/set_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,8 +40,6 @@ func TestNewSet(t *testing.T) {
assert.NoError(t, err)
assert.NotNil(t, set)

assert.Equal(t, set.GetStorage(), memStorage)

assert.Equal(t, len(cnf.Groups), len(set.groups))
assert.Equal(t, len(cnf.Groups[0].EnabledNames), len(set.groups[0].filters))

Expand Down
Loading