GH-22 - Changed delete character to icon in config settings component

[marianunez]

Summary

Changed delete character to icon in config settings component given that it was not properly rendering in Windows OS. See linked ticket.

Screenshots

Ticket Link

Fixes #22

[marianunez]

@asaadmahmood I updated the delete character to the trash icon as suggested which looks good but needs a bit of styling, seems a bit big:

Any suggestions to polish it?

[asaadmahmood]

@marianunez Not sure why its so big, we can just reduce the font size to 14 pixels or something.

[marianunez]

Font size did the trick:

[hahmadia]

Hey @marianunez ! A user made a good point about the Group's which initially I had missed (#24).

Not sure if it can happen in this PR or a separate one but it would be a good idea to hide the Groups field if the user doesn't have E20 license. In addition to this, it would be a good idea to update the README to mention how applying attribute to via Group ID is a feature only available to E20 customers and doesn't apply to others (to avoid the confusion mentioned in the ticket). Thanks!

[marianunez]

@hahmadia Sure. If you can point me how it should be checked for E20 (not familiar with licensing checks) I can go ahead and add it.

[hahmadia]

@hahmadia Sure. If you can point me how it should be checked for E20 (not familiar with licensing checks) I can go ahead and add it.

No worries. I think you can finish this PR and when I am back from PTO, I will create a new PR to address this issue. I am not currently available and wouldn't want to hold you back on merging this PR. Thanks!

[DHaussermann]

Good catch @hahmadia!

I have created a separate issue here #27 to address hiding the Group ID field when it is not applicable.

[DHaussermann]

Tested and passed

• Icon replaced with trash
• Tested on Windows and Mac to ensure the icon displays correctly
  LGTM! Thanks @marianunez

Will test again if any changes are requested from code review.

[DHaussermann]

@asaadmahmood I tested this after the icons were reduced in size. Did you want to review this again?

[aaronrothschild]

Hey @jfrerich Can we get this updated to pass Github ready for release? cc @DHaussermann @asaadmahmood

[jfrerich]

@aaronrothschild, I just approved.

[jfrerich]

LGTM!