Make image asset use HTTPS instead of HTTP #34
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fmartingr
reviewed
Nov 20, 2024
| @@ -186,7 +186,7 @@ func (p *Plugin) handleCreate(c *plugin.Context, args *model.CommandArgs, parame | |||
| Dialog: model.Dialog{ | |||
| CallbackId: fmt.Sprintf("create_%s", subcommand), | |||
| Title: fmt.Sprintf("Create a Google %s", cases.Title(language.English, cases.NoLower).String(subcommand)), | |||
| IconURL: "http://www.mattermost.org/wp-content/uploads/2016/04/icon.png", | |||
| IconURL: "https://www.mattermost.org/wp-content/uploads/2016/04/icon.png", | |||
There was a problem hiding this comment.
Should this be a Google Drive icon instead?
Isn't it better to bundle this icon in the plugin in case that file gets removed?
There was a problem hiding this comment.
@fmartingr I was wondering the same thing about it being bundled in the plugin as well.
As for which image it should be, I'm not 100% sure. It was a quick fix so I figured I would do it myself.
Maybe this warrants a ticket. @BenCookie95?
There was a problem hiding this comment.
Yeah we should probably bundle that in. I'll create a separate ticket
fmartingr
approved these changes
Nov 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
IconURLinserver/plugin/create.goutilize HTTPS instead of HTTP