Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make image asset use HTTPS instead of HTTP #34

Merged
merged 1 commit into from
Nov 21, 2024
Merged

Make image asset use HTTPS instead of HTTP #34

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion server/plugin/create.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -186,7 +186,7 @@ func (p *Plugin) handleCreate(c *plugin.Context, args *model.CommandArgs, parame
Dialog: model.Dialog{
CallbackId: fmt.Sprintf("create_%s", subcommand),
Title: fmt.Sprintf("Create a Google %s", cases.Title(language.English, cases.NoLower).String(subcommand)),
IconURL: "http://www.mattermost.org/wp-content/uploads/2016/04/icon.png",
IconURL: "https://www.mattermost.org/wp-content/uploads/2016/04/icon.png",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this be a Google Drive icon instead?
Isn't it better to bundle this icon in the plugin in case that file gets removed?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@fmartingr I was wondering the same thing about it being bundled in the plugin as well.
As for which image it should be, I'm not 100% sure. It was a quick fix so I figured I would do it myself.
Maybe this warrants a ticket. @BenCookie95?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah we should probably bundle that in. I'll create a separate ticket

Elements: []model.DialogElement{},
SubmitLabel: "Create",
NotifyOnCancel: false,
Expand Down