Update Makefile from starter template, upgrade node to v16, and remove mattermost-webapp dependency #229
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #229 +/- ##
======================================
Coverage 6.42% 6.42%
======================================
Files 11 11
Lines 1712 1712
======================================
Hits 110 110
Misses 1594 1594
Partials 8 8 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
I removed this file since the component this is testing hasn't changed since introduced, and the test hasn't provided much value. The "requirement" of removing had to do with removing enzyme, which required some dependencies that we don't want to keep around going forward. For plugins that have meaningful React tests, we'll want to replace usage of enzyme with @testing-library/react, just as the main webapp project has been using.
mickmister
added
2: Dev Review
|
@AayushChaudhary0001 This should just require a general smoke test |
mickmister
changed the title
| @@ -0,0 +1,33 @@ | |||
| module github.com/mattermost/mattermost-plugin-starter-template/build | |||
There was a problem hiding this comment.
I added build/go.mod to lessen the scope of this PR a bit. This way we don't introduce a bunch of changes to use mattermost/server/public in this PR. That will be done in a separate effort to sync all plugin projects with starter template
mickmister
changed the title
| @@ -0,0 +1,33 @@ | |||
| module github.com/mattermost/mattermost-plugin-starter-template/build | |||
|
Smoke test passes |
Summary
Ticket Link