Fixing the broken build by updating the Java Version.#115
Open
BrenoFariasdaSilva wants to merge 2 commits intomauricioaniche:masterfrom
Open
Fixing the broken build by updating the Java Version.#115BrenoFariasdaSilva wants to merge 2 commits intomauricioaniche:masterfrom
BrenoFariasdaSilva wants to merge 2 commits intomauricioaniche:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I have closed the previous PR after realizing an oversight: the work was inadvertently done directly on the master branch instead of a dedicated branch for the build fix. I only realized this when you mentioned in the old PR that there were many non-related commits to the PR.
Well, into the PR itself, initially my efforts were focused on updating dependencies without considering the compatibility with the Java version. This approach did not yield any positive outcomes. It prompted me to adopt a reverse research strategy, where I investigated the release dates of the problematic dependencies. The goal was to identify the timeframe of their release and use that information to deduce the corresponding Java version prevalent at that time.
After several attempts, this approach of aligning the dependencies with the appropriate Java version, based on their release years, proved to be successful. Although the PR is simple, it indeed took me a whole weekend to figure it out.